1646158 - Various clang-plugin updates for clang 11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Comment 1

[(Away)]

Attachment: Make `DynTypedNodeList` work with clang11

In https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082, the class DynTypedNodeList moved from ASTContext to global level.

Comment 2

[(Away)]

Attachment: Make nested template checks work with clang 11

Sometime during clang 11 (I don't have the exact commit handy), the display of nested templates changed from Foo<Bar<X> > to Foo<Bar<X>>.

Comment 3

[(Away)]

Attachment: Fix StringRef conversions in clang-plugin for clang 11

In https://github.com/llvm/llvm-project/commit/adcd02683856c30ba6f349279509acecd90063df, conversions from StringRef to std::string became explicit.

The NFC fix would be to wrap the conversions in std::string(...) but since these are all short-lived uses for things like string compares, I've refactored a bit to keep them in native form.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70b1b14bf281
Make nested template checks work with clang 11 r=static-analysis-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/6733a8ca5908
Make `DynTypedNodeList` work with clang11 r=static-analysis-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/50a3843bd942
Fix StringRef conversions in clang-plugin for clang 11 r=static-analysis-reviewers,andi

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/70b1b14bf281
https://hg.mozilla.org/mozilla-central/rev/6733a8ca5908
https://hg.mozilla.org/mozilla-central/rev/50a3843bd942