Closed Bug 1646183 Opened 4 years ago Closed 2 years ago

Write a rule to find and prevent unnecessary usages of XPCOMUtils.defineLazyGlobalGetters

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

3 Branch

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1415483 +++

As we did in bug 1415483 we should also prevent unnecessary usages of XPCOMUtils.defineLazyGlobalGetters.

I think we can extend the reject-importGlobalProperties rule to apply to this as well.

Assignee: nobody → standard8
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b67edade20f4 Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag https://hg.mozilla.org/integration/autoland/rev/0e5307c22c4b Use ESLint rule reject-importGlobalProperties to reject all imports in system modules. r=arai,webcompat-reviewers,twisniewski
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: