1501127 - Remove unnecessary calls to importGlobalProperties

Status: NEW

(Core :: DOM: Bindings (WebIDL), enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Since bug 1489301 all interfaces exposed on Window are also exposed on BackstagePass. This should mean that most calls to importGlobalProperties are no longer needed.

We should also change https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/js/xpconnect/src/XPCComponents.cpp#2342 to assert if we have a BackstagePass global.

See https://phabricator.services.mozilla.com/D9403#224288

Comment 1

[Kris Maglione [:kmag]]

N.B. We also need to remove unnecessary XPCOMUtils.defineLazyGlobalGetters calls.

Comment 2

[Mark Banner (:standard8)]

I've been working on a patch to remove some of these instances in bug 1415483. During this process I learned that currently we can't remove this everywhere:

- sjs files used in our test suites, still need to import the global properties. I'm not sure exactly how these are run.
- Child process files (e.g. toolkit/components/extensions/child/ext-userScripts.js)

I'm not sure if we can yet remove items not in the non-privileged list as well, e.g. fetch, crypto.