1646232 - Improve handling of "Text Encoding" in the appmenu

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task, P3)

Description

[Paul Morris [:pmorris]]

While reviewing the patch for bug 1645307, I found:

• A way to access the text encodings from mozilla-central/toolkit/modules/CharsetMenu.jsm rather than keeping a separate copy of them.
• When hovering the "appmenu > View > Text Encoding" menu item the CSS styles were not working correctly.
• The "appmenu > New > Other Accounts" menu item was not being disabled when the parallel one in the main menu was being disabled.

Patches on the way shortly.

Comment 1

[Paul Morris [:pmorris]]

Attachment: Bug 1646232 - Use text encodings from mozilla-central. r?darktrojan

Instead of keeping a separate copy of them.

Comment 2

[Paul Morris [:pmorris]]

Attachment: Bug 1646232 - Fix CSS style for hovering on "Text Encoding" item in appmenu. r=darktrojan

Setting disabled="false" was breaking the CSS rules, so remove
the attribute instead.

Depends on D79933

Comment 3

[Paul Morris [:pmorris]]

Attachment: Bug 1646232 - Disable the `appmenu > New > Other Accounts` menu item when needed. r?darktrojan

Depends on D79934

Comment 4

[Paul Morris [:pmorris]]

Try run just started: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=950278df8a9c43bf0ac1c4f4b201f2826abdcac1

Comment 5

[Paul Morris [:pmorris]]

Try run looks okay to me. Ready to land.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58cf90b93341
Use text encodings from mozilla-central. r=darktrojan
https://hg.mozilla.org/comm-central/rev/b330c1880a62
Fix CSS style for hovering on "Text Encoding" item in appmenu. r=darktrojan
https://hg.mozilla.org/comm-central/rev/2026ef96e5d5
Disable the appmenu > New > Other Accounts menu item when needed. r=darktrojan

Comment 7

[Magnus Melin [:mkmelin]]

FWIW, it would be easier to land if you put r= and not r? in the summaries. It's fairly easy to fix in a one-patch landing, but with the series... not too much fun.

Comment 8

[Paul Morris [:pmorris]]

(In reply to Magnus Melin [:mkmelin] from comment #7)

FWIW, it would be easier to land if you put r= and not r? in the summaries. It's fairly easy to fix in a one-patch landing, but with the series... not too much fun.

Okay, makes sense, I'll do r= instead.