1646296 - Group `WSRunScanner` members with stack only classes

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Some members of WSRunScanner should be grouped for managing them easily and making easier to create WSFragment without WSRunScanner.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 1: Make `WSRunScanner::FindNearestRun()` return `const WSFragment*` instead of `WSFragment*`

The result should never be modified so that it should return const-pointer.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 2: Split `WSRunScanner::GetWSNodes()`

Despite the name, it stores range of white-space sequence and/or start/end
reason. Initializing start and end are completely independent. Therefore,
we can move them into independent methods.

Depends on D79964

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 3: Create helper methods of `WSRunScanner::InitializeRange*()` to scan a text node

There are duplicated code in both WSRunScanner::InitializeRangeStart()
and WSRunScanner::InitializeRangeEnd(). They scan text node to store
first and last NBSP positions and initialize start/end with found visible
character position. This patch makes the loop clearer.

Depends on D79965

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 4: Make the loops in `WSRunScanner::InitializeRange*()` handle topmost `else` block first

Their topmost else blocks mean there is no visible content before/after the
point. In this case, the initialization is simpler. So, they should be
handled first, and make the other blocks outdented.

Depends on D79966

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 5: Make the last `else` block in the loops of `WSRunScanner::InitializeRange*()` handled before the text node case

Similar to the previous patch, this patch moves the last else block of
the loops in WSRunScanner::InitializeRangeStart() and
WSRunScanner::InitializeRangeEnd() to before the text node handling case.
This makes that clearer that the loops are continued only when text node
has no text or only white-spaces.

Depends on D79969

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 6: Make `WSRunScanner::InitializeRange*()` stop using the loops which are rarely run twice and more

With the previous patches, we know that the loops in
WSRunScanner::InitializeRangeStart() and WSRunScanner::InitializeRangeEnd()
rarely run twice and more. Therefore, we can make use recursive calls instead
of the loop.

Depends on D79970

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 7: Make `WSRunScanner::InitializeRange*()` template methods

Depends on D79971

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646296 - part 8: Make stack only classes to group start/end boundary information of `WSRunScanner`

Depends on D79972

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d950fc8920f
part 1: Make `WSRunScanner::FindNearestRun()` return `const WSFragment*` instead of `WSFragment*` r=m_kato

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ea75a91be0
part 2: Split `WSRunScanner::GetWSNodes()` r=m_kato

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8d950fc8920f

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/20ea75a91be0

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd3b637431ab
part 3: Create helper methods of `WSRunScanner::InitializeRange*()` to scan a text node r=m_kato

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/dd3b637431ab

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcc4bbf0b662
part 4: Make the loops in `WSRunScanner::InitializeRange*()` handle topmost `else` block first r=m_kato

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b6a6de28a3
part 5: Make the last `else` block in the loops of `WSRunScanner::InitializeRange*()` handled before the text node case r=m_kato

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaffca941228
part 6: Make `WSRunScanner::InitializeRange*()` stop using the loops which are rarely run twice and more r=m_kato

Comment 18

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dcc4bbf0b662
https://hg.mozilla.org/mozilla-central/rev/26b6a6de28a3

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75d781b31267
part 7: Make `WSRunScanner::InitializeRange*()` template methods r=m_kato

Comment 20

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eaffca941228
https://hg.mozilla.org/mozilla-central/rev/75d781b31267

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/135eb1ba22b6
part 8: Make stack only classes to group start/end boundary information of `WSRunScanner` r=m_kato

Comment 22

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/135eb1ba22b6