1646325 - Make `WSRunScanner` create `WSFragment`s only when needed

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In most WSRunScanner methods, WSFragments are not used, but they are initialized when WSRunScanner is created. For stopping unnecessary things, WSRunScanner should create part of them or all of them when they are needed.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 1-1: Make `WSRunScanner::GetRuns()` handle the case not starting from hard line break first r=m_kato!

Part 1-* rewrite WSRunScanner::GetRuns() with early-return style, but it's
hard to review if changing it with a patch.

This just swaps the if and else block because the else block is
shorter than the if block.

Depends on D79973

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 1-2: Rewrite the new `if` block in `WSRunScanner::GetRuns()` with early-return style r=m_kato!

Depends on D80311

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 1-3: Rewrite remaining part of `WSRunScanner::GetRuns()` with early-return style r=m_kato!

Depends on D80312

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 2: Manage `WSFragment`s with array

WSFragment is created at least one instance, and at most 3 instances per
WSRunScanner instance. They can be managed with AutoTArray simpler and
we can avoid heap allocation with this approach.

Depends on D80313

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 3: Make `WSFragment` non-double-linked-list

Now, WSFragment is managed by AutoTArray so that it does not need to
be double-linked-list.

Depends on D80314

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 4: Make `WSFragment` creates last fragment by itself

The last fragment which is for trailing white-spaces can be created with
previous fragment and end boundary data. Therefore, we can make WSFragment
create it by itself with taking WSRunScanner::mEnd.

Depends on D80315

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 5: Make `WSFragment::CreateNextOne()` create fragment for leading white-spaces

Similarly, it can handle 2nd fragment which is needed for leading white-spaces.

Depends on D80316

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 6: Create `WSFragment::CreateFirstOne()` for creating start fragment

Depends on D80317

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 7: Make `WSFragment::CreateFirstOne()` handle the case when the range does not start from hard line break

Depends on D80318

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 8: Make `WSFragment::CreateFirstOne()` handle the case that there is no NBSPs and before or after hard line break

Depends on D80319

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 9: Make `WSFragment::CreateFirstOne()` handle all cases

Unfortunately, in both CreateFirstOne() and CreateNextOne(), a lot of
checks are duplicated for avoiding to create unnecessary fragments. They
will be sorted out in the following patch.

Depends on D80320

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 10: Make `WSFragment` have utility methods to help to check whether it should be followed by another fragment or not

Unfortunately, mRightWSType may be different from end reason. Therefore,
the checker methods need to take end BoundaryData.

Depends on D80321

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 11: Make `WSRunScanner` create `WSFragment` when it's needed r=m_kato!

In most methods of WSRunScanner, WSFragments are never used. Therefore,
this patch makes them created when they are necessary.

Depends on D80322

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0f0b027ad4
part 1-1: Make `WSRunScanner::GetRuns()` handle the case not starting from hard line break first r=m_kato

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1646325 - part 4: Make `WSRunScanner` create `WSFragment` when it's needed r=m_kato!

In most methods of WSRunScanner, WSFragments are never used. Therefore,
this patch makes them created when they are necessary.

Depends on D80315

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/299013aba1c6
part 1-2: Rewrite the new `if` block in `WSRunScanner::GetRuns()` with early-return style r=m_kato

Comment 17

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1c0f0b027ad4
https://hg.mozilla.org/mozilla-central/rev/299013aba1c6

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4c91558120
part 1-3: Rewrite remaining part of `WSRunScanner::GetRuns()` with early-return style r=m_kato

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae9a82a6a0f0
part 2: Manage `WSFragment`s with array r=m_kato

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ac1eb89426
part 3: Make `WSFragment` non-double-linked-list r=m_kato

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5281b36d858
part 4: Make `WSRunScanner` create `WSFragment` when it's needed r=m_kato

Comment 22

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fd4c91558120
https://hg.mozilla.org/mozilla-central/rev/ae9a82a6a0f0
https://hg.mozilla.org/mozilla-central/rev/19ac1eb89426

Comment 23

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a5281b36d858