1647043 - Add IIN detection when saving a credit card

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We want to be able to detect the correct credit card type using IIN.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1647043 - Add support for IIN detection based on Credit Card Number.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0e045d2928
Add support for IIN detection based on Credit Card Number. r=abr

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple formautofill failures.

backout: https://hg.mozilla.org/integration/autoland/rev/24787602a9f6bc95a34930d3bc087d4ac54fe1a5

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0f0e045d29285c81be9176ea927831b21469aa06&selectedTaskRun=SoQQ_vmgQ6qW4_HKRCAbOg.0

failure logs:

• browser/extensions/formautofill/test/browser/creditCard/browser_editCreditCardDialog.js | unknown cc-type removed upon manual save - Got visa, expected undefined https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307027703&repo=autoland&lineNumber=4254
• browser/extensions/formautofill/test/unit/test_migrateRecords.js | xpcshell return code: 0 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307027626&repo=autoland&lineNumber=2978

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Agh, damn. The fact that formautofill tests fail on Linux hits me back. I'll fix it in the morning

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b323411b08ff
Add support for IIN detection based on Credit Card Number. r=abr

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b323411b08ff

Comment 7

[Alin Ilea, Desktop Test Engineering]

Attachment: Diners Club logo issue.png

Hi,

In my attempt to verify this, besides the issue already found by Matt (bug 1649028), I saw that the logo is not detect/displayed when submitting a Diners Club credit card. Reproduced in Beta 79.0b2 and latest Nightly 80.0a1 (2020-07-01). Both credit cards saved without logo (in the above screenshot) are Diners Club credit cards. The card with diners club logo its actually a Mastercard saved credit card.
Thanks.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Adam, when you added logos, is there a chance we missed Diners Club logo?

Comment 9

[Adam Roach [:abr]]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #8)

Adam, when you added logos, is there a chance we missed Diners Club logo?

The third card in the list in that screenshot has a Diner's Club logo next to it, so it's definitely in the tree and working, at least sometimes.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Can you please file it as a new bug

Comment 11

[Alin Ilea, Desktop Test Engineering]

Sure, here is the new submitted bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1650033

Comment 12

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Beta 79.0b6 and latest Nightly 80.0a1 (build id: 20200712091716). After the bug 1650033 has been fixed, the Diners Club logo is also detect when submitting a new credit card and displayed in saved credit cards (in Nightly 80.0a1).