1647087 - success-container not well aligned and focus ring around read-only fields

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

After bug 1627736 the success-container isn't well aligned, the checkmark and the close button are too high placed.

And in the key details dialog the read-only textfields have a focus ring.

Not focus of this bug, but I think that when opening the key details dialog, the focus shouldn't be on the owner textfield. Maybe, when I understand the code correctly, this https://searchfox.org/comm-central/source/mail/extensions/openpgp/content/ui/keyDetailsDlg.js#53 doesn't work as it should.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1647087-center-align-success-container.patch

Fix both issues.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: success-container.png

Screenshot of of the success-container before (above) and with (below) the patch.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9158007 [details] [diff] [review]
1647087-center-align-success-container.patch

Review of attachment 9158007 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks for taking care of it.
Just a little comment to be sure we're not affecting anything else with these CSS changes.

::: mail/themes/shared/mail/accountManage.css
@@ +266,5 @@
>    flex: 1;
>    background-color: transparent;
>    border-style: none;
> +  box-shadow: none !important;
> +  outline: none;

Since this class is used by other read-only input fields, are we sure we're not affecting any expected visual feedback throughout the account manager?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #3)

Since this class is used by other read-only input fields, are we sure we're
not affecting any expected visual feedback throughout the account manager?

The only other place is the SMTP server details box and the focus ring is also not wanted there.

Comment 5

[Alessandro Castellani [:aleca]]

Sounds good, thanks for checking.
Let's uplift this to beta as well.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9158007 [details] [diff] [review]
1647087-center-align-success-container.patch

[Approval Request Comment]
User impact if declined: not wanted visual appearance
Testing completed (on c-c, etc.): soon in c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9c5843e733a
Center align the content of the success-container and remove the focus on read-only textfields. r=aleca

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9158007 [details] [diff] [review]
1647087-center-align-success-container.patch

Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/518cb51abae5