1647116 - 'Apply columns to' dialog has an untranslated title

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Mark Banner (:standard8)]

Attachment: Broken UI

I just tried setting the columns to be all the same on multiple accounts.

When I did so, I got the message:

threadPane.columnPicker.confirmFolder.noChild.title

It looks like it should be using .message:

https://searchfox.org/comm-central/rev/d43074d7b70297d3e02d8725fc45e5b11870f49e/mail/base/content/mailWidgets.js#625-632

This is a regression from bug 1521016

Comment 1

[Magnus Melin [:mkmelin]]

Thanks for filing, and the details!

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1647116_apply_folder_msg.patch

Comment 3

[Khushil Mistry [:khushil324]]

Comment on attachment 9158038 [details] [diff] [review]
bug1647116_apply_folder_msg.patch

Review of attachment 9158038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ac23d03ff566
'Apply columns to' dialog has an untranslated title. r=khushil

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9158038 [details] [diff] [review]
bug1647116_apply_folder_msg.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1521016 (old regression apparently unnoticed for a whole esr cycle)
User impact if declined: showing the localization key instead of text for a dialog
Testing completed (on c-c, etc.):  yes
Risk to taking this patch (and alternatives if risky): low risk

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9158038 [details] [diff] [review]
bug1647116_apply_folder_msg.patch

approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/cf9b631ce5fa