1647186 - Consider factoring the pres shell's resolution value in the partial prerender area calculation

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: a reftest to see the issue

As Botond said in a review comment, partial pre-render should care the visual viewport region, so I started with a reftest with reftest-resolution (which means a static zoom value).

With the reftest, it turns out in the current implementation we don't expand the pre-render area in cases where "zoom < 1.0" value is applied.

Attaching file is a patch contains a reftest. To see the issue, you need the patch for bug 1646629.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1647186 - Apply the cumulative resolution smaller than 1.0 to the root frame size for the partial pre-render. r?botond

So that we can reasonably expand the pre-render region on mobile environments.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/290c0c7b9864
Apply the cumulative resolution smaller than 1.0 to the root frame size for the partial pre-render. r=botond

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failure on partial-prerender-expansion-with-resolution-2.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/e4ec47575ea36fe2ebec11d6e0173ec8fdaab768
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308606848&repo=autoland&lineNumber=16673

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e80da7e54fa6
Apply the cumulative resolution smaller than 1.0 to the root frame size for the partial pre-render. r=botond

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e80da7e54fa6