Closed Bug 1646629 Opened 2 years ago Closed 2 years ago

The reftest harness doesn't take the latest snapshot if reftest-no-flush is specified

Categories

(Testing :: Reftest, defect, P3)

defect

Tracking

(firefox77 wontfix, firefox78 wontfix, firefox79 wontfix, firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(2 files)

Because there is no MozAfterPaint fired by changes for animations on the compositor.

It seems to have been regressed since bug 1349991.

Attaching file is a patch containing a reftest you can see the issue.

The testing HTML has a transform animation runs on the compositor. When you run the reftest locally, you will see a big green circle moves downward, but if you see the reftest failure log on the reftest analyzer, you will see that the green circle is positioned at the initial place. That's because we never call SendUpdateCanvasForEvent after we took the initial snapshot because there is no MozAfterPaint events.

Presumably to fix this issue, we need to set updateCanvasPending to true and set updateCanvasRects to the whole area after "reftest-wait" is removed if reftest-no-flush is specified.

Interestingly I can observe MozAfterEvents by compositor animations on non-E10S. :)

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3

I had blocked a wrong bug. :)

Blocks: 1324591
No longer blocks: 1349991
Attachment #9157574 - Attachment description: Bug 1646629 - Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r?mattwoodrow,tnikkel → Bug 1646629 - Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r?mattwoodrow!,tnikkel!
Blocks: 1647186
Blocks: 1650351
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1729ebd90c68
Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r=mattwoodrow,tnikkel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

The patch landed in nightly and beta is affected.
:hiro, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(hikezoe.birchill)
Flags: needinfo?(hikezoe.birchill)
You need to log in before you can comment on or make changes to this bug.