1646629 - The reftest harness doesn't take the latest snapshot if reftest-no-flush is specified

Status: RESOLVED FIXED

(Testing :: Reftest, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Because there is no MozAfterPaint fired by changes for animations on the compositor.

It seems to have been regressed since bug 1349991.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A reftest you can see the issue

Attaching file is a patch containing a reftest you can see the issue.

The testing HTML has a transform animation runs on the compositor. When you run the reftest locally, you will see a big green circle moves downward, but if you see the reftest failure log on the reftest analyzer, you will see that the green circle is positioned at the initial place. That's because we never call SendUpdateCanvasForEvent after we took the initial snapshot because there is no MozAfterPaint events.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Presumably to fix this issue, we need to set updateCanvasPending to true and set updateCanvasRects to the whole area after "reftest-wait" is removed if reftest-no-flush is specified.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Interestingly I can observe MozAfterEvents by compositor animations on non-E10S. :)

Comment 4

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d968ad15fe58685a351ec8cc3ca9a4c5c5e5ec72

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646629 - Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r?mattwoodrow!,tnikkel!

That's because we no longer fire MozAfterPaint event for changes by
animations on the compositor.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

I had blocked a wrong bug. :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1729ebd90c68
Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r=mattwoodrow,tnikkel

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1729ebd90c68

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hiro, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.