1647205 - Extension don't work in first tab after session restore

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[gwarser]

Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
Build ID 20200621093846

STR:

• clean profile
• enable session restore
• install https://addons.mozilla.org/en-US/firefox/addon/drag-select-link-text/
• open new tab
• close all other tabs
• close browser
• start browser
• click on wikipedia tile in top sites (I did it as soon as possible, not sure if important)
• horizontally drag one of the links around wiki globe
  • text should be selected (expected)
• open new tab
• close all other tabs
• close browser
• start browser
• click on wikipedia tile in top sites (I did it as soon as possible, not sure if important)
• horizontally drag one of the links around wiki globe
  • link is dragged (this is not expected)

Other symptom is - Firefox native screenshots tool context menu stops working and after tab is closed send notification: "We can't screenshot this page, This isn’t a standard Web page, so you can’t take a screenshot of it."

24:14.04 INFO: Running autoland build built on 2020-06-11 05:34:27.114000, revision 61bdbb94
24:27.06 INFO: Launching /tmp/tmp9xj0yszr/firefox/firefox
24:27.06 INFO: Application command: /tmp/tmp9xj0yszr/firefox/firefox --allow-downgrade -profile /tmp/tmppr34yvw4.mozrunner
24:27.08 INFO: application_buildid: 20200611034550
24:27.08 INFO: application_changeset: 61bdbb94ab7abd434c60e2a40fa9f07b11237ebb
24:27.08 INFO: application_name: Firefox
24:27.08 INFO: application_repository: https://hg.mozilla.org/integration/autoland
24:27.08 INFO: application_version: 79.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
25:18.33 INFO: Narrowed integration regression window from [fdd5f38d, 9b3cf294] (3 builds) to [61bdbb94, 9b3cf294] (2 builds) (~1 steps left)
25:18.33 INFO: No more integration revisions, bisection finished.
25:18.33 INFO: Last good revision: 61bdbb94ab7abd434c60e2a40fa9f07b11237ebb
25:18.33 INFO: First bad revision: 9b3cf2944aa064c840285247fa62cdf26e203935
25:18.33 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=61bdbb94ab7abd434c60e2a40fa9f07b11237ebb&tochange=9b3cf2944aa064c840285247fa62cdf26e203935

(running mozregression I need to manually execute "Application command" second time)

Toggling fission.preserve_browsing_contexts to false fixes this, so it's probably bug 1550571

Observations: in my dirty profile looks like all extensions (content scripts?)(uBlock Origin cosmetic filtering) stop working when at least one script throws exception. They may throw because of conflict with some other contexts (?), for example above extensions logs this in console:

SyntaxError: redeclaration of const HOLD_GESTURES content.js:1:1

but I don't see any other declarations of HOLD_GESTURES

Disabling Cookie Auto Delete, Simple Translate and SuperStop which show some errors in console allows other extensions (uBlockO) to work.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1550571

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

pbone: assuming this was regressed by bug 1550571, can you please have a look?

Comment 3

[gwarser]

Mozregression run with --pref fission.preserve_browsing_contexts:true returns:

41:35.38 INFO: Running autoland build built on 2020-03-09 21:25:26.856000, revision 3004bc75
41:46.14 INFO: Launching /tmp/tmpeq7vay01/firefox/firefox
41:46.14 INFO: Application command: /tmp/tmpeq7vay01/firefox/firefox --allow-downgrade -profile /tmp/tmp357z15yz.mozrunner
41:46.15 INFO: application_buildid: 20200309195418
41:46.15 INFO: application_changeset: 3004bc7597a088e181fbcb9a9044b8d952e9d45f
41:46.15 INFO: application_name: Firefox
41:46.15 INFO: application_repository: https://hg.mozilla.org/integration/autoland
41:46.15 INFO: application_version: 75.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
42:38.00 INFO: Narrowed integration regression window from [f6f182f7, 5b47cfca] (3 builds) to [3004bc75, 5b47cfca] (2 builds) (~1 steps left)
42:38.00 INFO: No more integration revisions, bisection finished.
42:38.00 INFO: Last good revision: 3004bc7597a088e181fbcb9a9044b8d952e9d45f
42:38.00 INFO: First bad revision: 5b47cfcab1554c89400b7a6299ff0cabac4bda0c
42:38.00 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3004bc7597a088e181fbcb9a9044b8d952e9d45f&tochange=5b47cfcab1554c89400b7a6299ff0cabac4bda0c

Comment 4

[gwarser]

Another preference?!?!

For:

 mozregression --good 2020-03-08 --bad 2020-03-10  --profile-persistence=clone-first --pref fission.preserve_browsing_contexts:true --pref browser.tabs.remote.separatePrivilegedContentProcess:false

both build are good.

https://hg.mozilla.org/integration/autoland/rev/718652138136a4e4903197925698b752a5c793b6

Comment 5

[Alice0775 White]

I can reproduce the issue on Nightly79.0a1 windows10, but not on 78.0RC.

Comment 6

[Paul Bone [:pbone]]

Working on this now.

Comment 7

[Paul Bone [:pbone]]

[Tracking Requested - why for this release]: Tracking for 80 as we did for 79.

I've marked as disabled for 79 because I'm expecting Bug 1649125 to uplift. Is that correct ryanvm?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Correct, now that the disabling patch has landed :)

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1647205: Remove `getWinUtils` helper. r=zombie

It isn't useful now that there is a Window.windowUtils WebIDL getter, and it
causes problems in the face of certain WeakMap issues.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20a8dadac9e3
Remove `getWinUtils` helper. r=zombie

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/20a8dadac9e3

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/20a8dadac9e3