1650979 - Let BrowsingContext preservation ride the trains

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Paul Bone [:pbone]]

BC preservation is enabled in nightly but won't ride the trains (Bug 1649125) because there are regressions (Bugs 1581500, 1631329, 1647109, 1647205, 1649457). Once these are fixed we can let it ride the trains.

Comment 1

[Paul Bone [:pbone]]

There's only one bug preventing this from riding the trains, and we're not even sure if that bug is caused by BC preservation. I want to give it another week before enabling this to ride the trains.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1650979 - Let BC preservation ride the trains r=kmag

Comment 3

[Chris Peterson [:cpeterson]]

Instead of riding the trains with Fx80, our new plan is to rollout BC Preservation using a remote pref flip for a percentage of users in Fx81 Nightly/Beta/Release.

Comment 4

[Paul Bone [:pbone]]

To clarify what Chris has said. It's already on for 100% of nightly users. The remote pref flip is for beta & release AIUI.

Comment 5

[Chris Peterson [:cpeterson]]

To reduce QA scope and because we see more crashes from Fenix Nightly users than from desktop Nightly users (bug 1650257), we plan to let BrowsingContext Preservation ride the trains on desktop (Windows, macOS, Linux) before mobile.

Comment 7

[Chris Peterson [:cpeterson]]

I forked "Let BrowsingContext Preservation ride the trains on mobile" bug 1658609 from this bug, but that was when we still suspected kmag's RecvNewWindowGlobal crash bug 1650257 was related to BrowsingContext Preservation. kmag and Nika no longer think that crash is related, so we can use this bug to let BrowsingContext Preservation ride the trains on both desktop and Android.

Comment 8

[Paul Bone [:pbone]]

We're ready for this to go with FF81 to release.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d90d8fb0a29
Let BC preservation ride the trains r=cpeterson

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7d90d8fb0a29

Comment 11

[Paul Bone [:pbone]]

Comment on attachment 9164218 [details]
Bug 1650979 - Let BC preservation ride the trains r=kmag

Beta/Release Uplift Approval Request

• User impact if declined: None, this feature (or it's absence) should be invisible to users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This has been enabled in Nightly for a couple of cycles and in Beta with the EARY_BETA_OR_EARLIER flag. This change will enable the feature in late beta and release.
• String changes made/needed: None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9164218 [details]
Bug 1650979 - Let BC preservation ride the trains r=kmag

Approved for 81.0b7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e46fbe0510ba