1647212 - Clean up in-tree mozconfigs

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Geoff Lankow (:darktrojan)]

There's a few mozconfig things I'd like to tidy up:

• It's not clear (to me at least) why macosx64/nightly has the line ac_add_options --disable-install-strip when none of the others do, and no Firefox configs for this platform do. Also it's incompatible with artifact builds so Try runs fail.
• The win*/debug configs should be rearranged to match their nightly counterparts. In particular the inclusion of $topsrcdir/comm/mail/config/mozconfigs/common should be much lower down. This also breaks artifact Try runs.
• MOZ_REQUIRE_ADDON_SIGNING=0 does nothing now and should be removed.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1647212 - Clean up in-tree mozconfigs. r?rjl

• Removed MOZ_AUTOMATION_L10N_CHECK and MOZ_REQUIRE_ADDON_SIGNING as they're unused.
• Removed --enable-jemalloc as it's enabled by default.
• Removed --disable-install-strip from macosx64/nightly as it seems to be erroneous.
• Ensured consistency of options and order across platforms and build types.

Comment 2

[Rob Lemley [:rjl]]

Could hold off on landing this until after merge day on 6/27 -- it's bound to break the merge day scripts and I'd rather not do that right now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/320088c8750b
Clean up in-tree mozconfigs. r=rjl