1647227 - "Run Junk Mail Controls" does not give feedback - window.MsgStatusFeedback is undefined

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Bill Dietrich]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Opened a message in the Junk folder, right-clicked and selected Mark / Run Junk Mail Controls.

I do have "Enable adaptive junk filter logging" enabled, although I would expect to see some UI regardless of the setting of this.

I'm running TB 78.0b2 64-bit on Ubuntu 20.04 GNOME.

Actual results:

Nothing happened, no dialog or UI or anything.

Expected results:

Expect to see some dialog to do Junk mail controls.

Comment 1

[Bill Dietrich]

Why was this changed to "enhancement" ? As far as I can tell, the feature does not work at all. It's a defect.

Comment 2

[Bill Dietrich]

Please change this back to "defect".

Comment 3

[Magnus Melin [:mkmelin]]

It does provide (quick) feedback in the status bar. For activity manager there is bug 1544471.
It may happen too quickly to notice though.

I'm grabbing this bug to fix that, since on trunk/beta we have a bug so it doesn't work at all.

Uncaught TypeError: window.MsgStatusFeedback is undefined
onMessageClassified chrome://messenger/content/junkCommands.js:245
junkCommands.js:245:7

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1647227 - "Run Junk Mail Controls" does not give feedback - window.MsgStatusFeedback is undefined. r=aleca

Fix the issue on trunk (window vs top.window), clean up documentation, and add a 500ms delay before removing the status message from the status bar.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b864dfb7131
"Run Junk Mail Controls" does not give feedback - window.MsgStatusFeedback is undefined. r=aleca