1647254 - parse_scalars.py: Undefined variable 'MAX_LENGTH_COUNT' E0602 (pylint)

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

/home/sylvestre/dev/mozilla/mozilla-central.hg/toolkit/components/telemetry/build_scripts/mozparsers/parse_scalars.py
  198:79  error  Undefined variable 'MAX_LENGTH_COUNT'  E0602 (pylint)

The error message won't be displayed

To reproduce :

$  ./mach lint -l pylint -n toolkit/components/telemetry/build_scripts/mozparsers/parse_scalars.py   

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Taegeon Lee]

Attachment: Bug 1647254 Change 'MAX_LENGTH_COUNT' to 'MAX_KEY_LENGTH' r=Sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b9c0602e19d
Change 'MAX_LENGTH_COUNT' to 'MAX_KEY_LENGTH' r=sylvestre

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5b9c0602e19d

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Taegeon, if you want, you can add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml, thanks

Comment 5

[Taegeon Lee]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Taegeon, if you want, you can add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml, thanks

Can I create a good-first-bug for other new contributors?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

sounds great, thanks :)

Comment 7

[Taegeon Lee]

I completed to create bug 1648027.