1648027 - add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Taegeon Lee]

+++ This bug was initially created as a clone of Bug #1647254 +++

According to bug 1647254 comment #4, Sylvestre Ledru [:Sylvestre] said

If you want, you can add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml, thanks.

I create a good-first-bug for other new contributors to learn how to contriburte Firefox.

Comment 1

[Bruno Bartolomasi]

I'm new here, can I work on this bug?

Comment 2

[Shivam Singhal [ :championshuttler ]]

Bruno, sure thanks , feel free to ask if you get stuck

Comment 3

[Bruno Bartolomasi]

Attachment: Bug 1648027 - Add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml

Comment 4

[Bruno Bartolomasi]

Attachment: Bug 1648027 - update repo

Comment 5

[Bruno Bartolomasi]

Hello Shivam, I'm stuck, could you help me?

this bug is closed: https://bugzilla.mozilla.org/show_bug.cgi?id=1650306, but I keep getting this error: https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=NRkUEmbBShWOvEy_lDWm4g.0&revision=85ea8d8a0e558a72d12cceddde184c4d6f143ab2 .

I was asked to fix it in a separate commit, I don't understand what went wrong. If the issue is already fixed and my code base was updated, why did it happen? What should I do? I'm thinking that copying that changes made in the fixed file is not the right thing to do.

Thank you for your help.

Comment 6

[Shivam Singhal [ :championshuttler ]]

Hi,

As far I know, you are getting those errors because you are enabling the pylint on toolkit/components/telemetry/ so pylint will tell you the problems in this particular directory, so as Sylvestre mentioned you need to fix those as well in a separate commit. Let me know if you need any help. Thanks for working on it :)

Comment 7

[Bruno Bartolomasi]

Attachment: Bug 1648027 - Fix linting failures 'unnecessary else after return'

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adddc0f9a43f
Fix linting failures 'unnecessary else after return' r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/f2bfe1ce958d
Add toolkit/components/telemetry/ in the include list of tools/lint/pylint.yml r=sylvestre

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/adddc0f9a43f
https://hg.mozilla.org/mozilla-central/rev/f2bfe1ce958d