Closed Bug 1647313 Opened 4 years ago Closed 4 years ago

Intermittent toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The window has a badge. -

Categories

(Toolkit :: Application Update, defect, P5)

defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bytesized)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disable-recommended])

Attachments

(2 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=307074427&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/BXxA5goHS5GqAbwyU2_MOQ/runs/0/artifacts/public/logs/live_backing.log


[task 2020-06-22T14:17:35.986Z] 14:17:35 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The window's doorhanger is closed. -
[task 2020-06-22T14:17:35.986Z] 14:17:35 INFO - Buffered messages finished
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The window has a badge. -
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - Stack trace:
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js:aboutDialog_restart_notification:37
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:683
[task 2020-06-22T14:17:35.993Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:846
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The restart badge is showing for the background window - Got , expected update-restart
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - Stack trace:
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js:aboutDialog_restart_notification:41
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:683
[task 2020-06-22T14:17:35.994Z] 14:17:35 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:846
[task 2020-06-22T14:17:36.045Z] 14:17:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The panel ID should equal apply -
[task 2020-06-22T14:17:36.045Z] 14:17:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | There should be an active update -

Looking at the test I added in bug 1642754, there may be a race where the update is still downloading a the time the test checks for the restart badge. I am investigating.

There are 83 total failures in the last 7 days on

  • linux1804-64 debug
  • macosx1014-64 debug
  • windows10-64 debug
  • windows7-32 ddebug

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318204824&repo=autoland&lineNumber=27615

[task 2020-10-09T18:48:34.802Z] 18:48:34 INFO - TEST-START | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js
[task 2020-10-09T18:48:34.929Z] 18:48:34 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x12952ec00 == 18 [pid = 1693] [id = 17]
[task 2020-10-09T18:48:34.929Z] 18:48:34 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 35 (0x1316fb6a0) [pid = 1693] [serial = 35] [outer = 0x0]
[task 2020-10-09T18:48:34.929Z] 18:48:34 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 36 (0x12f522000) [pid = 1693] [serial = 36] [outer = 0x1316fb6a0]
[task 2020-10-09T18:48:34.973Z] 18:48:34 INFO - GECKO(1693) | [Parent 1693, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4280
[task 2020-10-09T18:48:35.067Z] 18:48:35 INFO - GECKO(1693) | [Child 1696: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x1040ec800) [pid = 1696] [serial = 2] [outer = 0x0] [url = about:blank]
[task 2020-10-09T18:48:35.067Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp:2804
[task 2020-10-09T18:48:35.392Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x129a2b800 == 17 [pid = 1693] [id = 11] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.392Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12e9abc00 == 16 [pid = 1693] [id = 10] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.392Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12a2e4400 == 15 [pid = 1693] [id = 8] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.393Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12eceec00 == 14 [pid = 1693] [id = 9] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.393Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12c822c00 == 13 [pid = 1693] [id = 7] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.393Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12c86ac00 == 12 [pid = 1693] [id = 13] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:35.393Z] 18:48:35 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12c81c000 == 11 [pid = 1693] [id = 12] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:36.155Z] 18:48:36 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 35 (0x128cac7d0) [pid = 1693] [serial = 10] [outer = 0x0] [url = about:blank]
[task 2020-10-09T18:48:36.155Z] 18:48:36 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 34 (0x128cac9a0) [pid = 1693] [serial = 9] [outer = 0x0] [url = about:blank]
[task 2020-10-09T18:48:36.155Z] 18:48:36 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 33 (0x12e24ab70) [pid = 1693] [serial = 15] [outer = 0x0] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:36.156Z] 18:48:36 INFO - GECKO(1693) | [Parent 1693: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 32 (0x12e24de30) [pid = 1693] [serial = 17] [outer = 0x0] [url = chrome://browser/content/aboutDialog.xhtml]
[task 2020-10-09T18:48:36.180Z] 18:48:36 INFO - TEST-INFO | started process screencapture
[task 2020-10-09T18:48:36.360Z] 18:48:36 INFO - TEST-INFO | screencapture: exit 0
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Buffered messages logged at 18:48:34
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Entering test bound setupTestCommon
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Leaving test bound setupTestCommon
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Entering test bound aboutDialog_foregroundCheck_downloadAuto
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Buffered messages logged at 18:48:35
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | About dialog appeared -
[task 2020-10-09T18:48:36.361Z] 18:48:36 INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - Version: 2.1 INTEL-12.9.22
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - Vendor: Intel Inc.
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - FBO Texture Target: TEXTURE_2D
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The panel ID should equal checkingForUpdates -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | There should not be a downloading update -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | There should not be a ready update -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - Buffered messages logged at 18:48:36
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The panel ID should equal downloading -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | There should be an active update -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The active update state should equal downloading -
[task 2020-10-09T18:48:36.362Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The window's doorhanger is closed. -
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - Buffered messages finished
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The window has a badge. -
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - Stack trace:
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js:aboutDialog_restart_notification:37
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:725
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:916
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The restart badge is showing for the background window - Got "", expected "update-restart"
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - Stack trace:
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js:aboutDialog_restart_notification:41
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:725
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:916
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The panel ID should equal apply -
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | There should be an active update -
[task 2020-10-09T18:48:36.363Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The active update state should equal pending -
[task 2020-10-09T18:48:36.519Z] 18:48:36 INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | The button should be enabled -
[task 2020-10-09T18:48:36.519Z] 18:48:36 INFO - Leaving test bound aboutDialog_foregroundCheck_downloadAuto
[task 2020-10-09T18:48:36.582Z] 18:48:36 INFO - GECKO(1693) | MEMORY STAT | vsize 7640MB | residentFast 345MB | heapAllocated 140MB
[task 2020-10-09T18:48:36.582Z] 18:48:36 INFO - TEST-OK | toolkit/mozapps/update/tests/browser/browser_aboutDialog_fc_downloadAuto.js | took 1773ms
[task 2020-10-09T18:48:36.582Z] 18:48:36 INFO - GECKO(1693) | [Child 1695: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x1164ec800 == 3 [pid = 1695] [id = 6]
[task 2020-10-09T18:48:36.583Z] 18:48:36 INFO - GECKO(1693) | [Child 1695: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (0x10f1099f0) [pid = 1695] [serial = 15] [outer = 0x0]
[task 2020-10-09T18:48:36.583Z] 18:48:36 INFO - GECKO(1693) | [Child 1695: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 12 (0x1165a2000) [pid = 1695] [serial = 16] [outer = 0x10f1099f0]
[task 2020-10-09T18:48:36.625Z] 18:48:36 INFO - checking window state

Kirk can the failure rate increase be from bug 1668096?

Flags: needinfo?(ksteuber)
Whiteboard: [stockwell needswork:owner]

Didn't disable it in browser.bits.ini - from the logs, the bits pref gets set
to false before the failures.

Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6f08796b50c
disable browser_aboutDialog_fc_downloadAuto.js due to frequent failures. r=jmaher DONTBUILD
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Assignee: aryx.bugmail → nobody
Status: ASSIGNED → NEW

I spent some time looking at this test today. I think I've got a patch that should fix it up. I'll post it shortly.

Flags: needinfo?(ksteuber)

Updated tests to wait a moment for the update badge. The badge is added on a timeout, so it may not be there when we first look.

Some tests actually already use this mechanism:
browser_doorhanger_bc_downloadOptIn_bgWin.js
browser_doorhanger_bc_downloadAutoFailures_bgWin.js
I'm not sure why it wasn't used consistently, but it seems to fix the intermittent failures with browser_aboutDialog_fc_downloadAuto.js to add the mechanism.

Assignee: nobody → ksteuber
Status: NEW → ASSIGNED
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d71b5c02b502
Fix update tests to wait on the update badge before they test for it r=mhowell
Regressions: 1671725
Keywords: leave-open
Whiteboard: [stockwell disabled]
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Whiteboard: [stockwell disable-recommended]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: