1647356 - Make some borders one device pixel in the Firefox front-end.

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Per the discussion in https://phabricator.services.mozilla.com/D79602 we probably want this change, so splitting to a meaningful bug.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647356 - Make some borders one device pixel, to ensure they're not fractional. r=dao,gijs

Note that this means that in HiDPI displays these borders will still be
1 device pixel, rather than one CSS pixel, so this technically is a
minor change for such displays.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b4e057f8cd9
Make some borders one device pixel, to ensure they're not fractional. r=dao

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9b4e057f8cd9

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing for causing bug 1648265 as per request.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48988c70e385
Backed out changeset 9b4e057f8cd9 for causing bug 1648265. CLOSED TREE

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647356 - Reduce size of some borders again and simplify tabs-navbar separator. r=dao!,#theme!

Use 1 device pixel (borders are rounded up to that) for these borders.

Bug 1889244 should prevent this from bouncing again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2cb8b6d9738
Reduce size of some borders again and simplify tabs-navbar separator. r=dao,desktop-theme-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26f475fb8d5a
Follow-up: Prevent flicker due to lazy initialization of tabs toolbar border.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b5ace939449
Revert tab nabvar separator simplification, for causing flickering on windows tests.
https://hg.mozilla.org/integration/autoland/rev/0561e7809f9e
Fix some WPT tests which are broken with fractional viewport sizes.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45519 for changes under testing/web-platform/tests

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e2cb8b6d9738
https://hg.mozilla.org/mozilla-central/rev/26f475fb8d5a
https://hg.mozilla.org/mozilla-central/rev/1b5ace939449
https://hg.mozilla.org/mozilla-central/rev/0561e7809f9e

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot