1889463 - Reland nav-bar separator simplification from bug 1647356 along with a fix for uneven spacing around urlbar if theme suppresses it

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1889463 - Re-land tabs-navbar-separator simplification, suppressing it completely if transparent. r=#theme!

Bug 1647356 made it so that the border takes space, which is generally
good and simplified some code. But if we set the separator color to
transparent (like many even builtin themes do), then the space at the
top and bottom of the urlbar looks un-even.

This is technically already an issue if a theme sets the
chrome-content-separator-color to transparent, but I think that's
really uncommon, and we don't want to encourage themes to suppress that
separator IMO... we might want to forbid that even somehow?

So for now only handle the tabs separator. Clean-up some adjacent code
while at it.

An alternative would be to go back to the shadow, and add some comments
as for why it's a shadow and not a border, but that seems to subtly
complicate layout in other places (which were working around it before
the regressing bug).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647356

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1889463 - Prevent flickering with the previous patch. r=dao!

The toolbar height includes the top border now. It's not what we want
anyways:

• In some cases its usage was completely redundant (we can use the
  default static position).

• In other cases what we want is the urlbar-container height, which
  doesn't include that border. I confirmed this looks good in compact
  mode (which was the reason for introducing this in bug 1580248).

So simplify the code a tiny bit and fix the flickering that got the
original version reverted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/762ecfd53753
Re-land tabs-navbar-separator simplification, suppressing it completely if transparent. r=desktop-theme-reviewers,tabbrowser-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/68a4c335386a
Prevent flickering with the previous patch. r=dao,desktop-theme-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/762ecfd53753
https://hg.mozilla.org/mozilla-central/rev/68a4c335386a