Closed Bug 1647431 Opened 5 years ago Closed 5 years ago

Fix use of GetTopLevelContentDocument in Document::ReportShadowDOMUsage

Categories

(Core :: DOM: Core & HTML, task, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: kmag, Assigned: smaug)

References

Details

Attachments

(1 file)

Bug 1647431, make ReportShadowDOMUsage Fission compatible, r=edgar
47 bytes, text/x-phabricator-request
Details | Review

GetTopLevelContentDocument returns null when the top-level document is in a different process, or there are cross-process interstitials between it and the current document. This means that for these frames, shadow DOM usage is never reported.

Severity: -- → S3
Fission Milestone: --- → ?

Olli, how critical would this be for Fission?

Flags: needinfo?(bugs)

Not critical. This is just a rather nice helper when debugging web sites possibly using Shadow DOM.

Let me fix this.

Assignee: nobody → bugs
Flags: needinfo?(bugs)
Fission Milestone: ? → M7
Severity: S3 → N/A
Status: NEW → ASSIGNED
Type: defect → task
Priority: -- → P4
Priority: P4 → P3
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d2ddbf83ab9 make ReportShadowDOMUsage Fission compatible, r=edgar

https://hg.mozilla.org/mozilla-central/rev/3d2ddbf83ab9

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: