1647435 - Fix use of GetTopLevelContentDocument in PaymentRequest::Constructor

Status: RESOLVED DUPLICATE of bug 1721897

(Core :: DOM: Web Payments, defect, P3)

Description

[Kris Maglione [:kmag]]

It will return null when the top-level document is cross-process, or there are cross-process interstitials between it and the document for which the constructor was called, which will lead to a null pointer crash.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Should this have a Fission milestone assigned?

Comment 2

[Kris Maglione [:kmag]]

(In reply to Simon Giesecke [:sg] [he/him] from comment #1)

Should this have a Fission milestone assigned?

It should be assigned during tomorrow's triage.

Comment 3

[Neha Kochar [:neha]]

This seems to have missed our triage

Comment 4

[Chris Peterson [:cpeterson]]

Fission Future because PaymentRequest API is currently disabled.

Comment 5

[Chris Peterson [:cpeterson]]

Jens, is there a meta bug for shipping the PaymentRequest API? I found bug 1481971 about enabling the PaymentRequest API in Nightly, but no meta bugs about letting the API ride the trains.

This Fission bug will need to be fixed before PaymentRequest API can ride the trains.

Comment 6

[Eden Chuang[:edenchuang]]

Hello Chris

Currently, PaymentRequest API is not enabled. And I think it would not be enabled in a short time since we only have an experimental UI for it.
Testcases for it are also disabled currently. I don't think it would be a big issue for shipping Fission. but we still need to fix this.
I think this is a duplicate of bug 1646556. There is a r+ patch when I was on a long leave. I will try to land it these days.

Comment 8

[Kris Maglione [:kmag]]

The GetTopLevelContentDocument usage in PaymentRequest::Constructor wasn't fixed by the patch in bug 1646556.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Eden fixed this in bug 1721897 because the null pointer crash manifested as a crash report.