1647551 - Ensure "platform" override in Emulation.setUserAgentOverride applies only to the current tab

Status: RESOLVED WONTFIX

(Remote Protocol :: CDP, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In Bug 1595710, we added support for "platform" to Emulation.setUserAgentOverride, which applies the platform override to all targets / tabs at once. This bug covers looking at applying the platform override to the current tab only.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Hi Nika and smaug, I think we're looking at implementing a "platform" override similar to general.platform.override onto the docShell so that we emulate the returned navigator.platform per tab instead of the global setting. Wanted to get your general thoughts about the approach and more guidance on how to contribute the change to the docShell.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that it might be similar to the user agent override, which works like a charm via the docShell.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

You probably want to add a synced field to the BrowsingContext like PlatformOverride and set it from the parent process. You'd then read it from the BrowsingContext in the corresponding child process to return the correct value.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Closing this since we are already working on Bug 1647972 first to avoid overriding the platform for all targets.