1647972 - Add a new PlatformOverride field onto BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

As part of https://bugzilla.mozilla.org/show_bug.cgi?id=1647551#c3, we want to add a synced field to the BrowsingContext for handling PlatformOverride.

Comment 1

[Chris Peterson [:cpeterson]]

Doesn't block Fission because this is a new feature.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f35e601f2cf56ee45426d05fd26b0dee8d661d3d

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1647972 - Add a new PlatformOverride field onto BrowsingContext

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

:whimboo, do we expect the platform to be also emulate when it goes over the network?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Is there a specific field in the HTTP request for the platform? Or is it just part of the user agent if not overriden? I think we should check what CDP/Chrome actually does, when the platform gets emulated.

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #5)

Is there a specific field in the HTTP request for the platform? Or is it just part of the user agent if not overriden? I think we should check what CDP/Chrome actually does, when the platform gets emulated.

You are right there's no specific field in the HTTP request for platform. It should just be the User-Agent headers that includes the platform. Let's follow up on this after investigating how CDP/Chrome emulates it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b96146ff2d78
Add a new PlatformOverride field onto BrowsingContext r=smaug

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b96146ff2d78