Closed Bug 1647840 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 24319 - Implement Storage Access commands for TestDriver

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 24319 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24319
Details from upstream follow.

Brandon Walderman <brwalder@microsoft.com> wrote:

Implement Storage Access commands for TestDriver

This change implements the Set Storage Access command for TestDriver in
Blink and content_shell:
https://privacycg.github.io/storage-access/#automation

This is needed to support more in-depth WPT tests for the Storage
Access API. The current WPT tests for this feature cover basic IDL
behavior, but are not able to verify that the requestStorageAccess API
itself is functional because the browser must first be put into a state
where third-party cookies are blocked.

A new set_storage_access method has been added to testdriver.js. It
functions similarly to the existing set_permission method. This calls a
Blink-internal method that forwards the passed in arguments to the
content shell via Mojo. A new WebTestStorageAccessManager class in the
content shell converts the arguments into ContentSettingsPatterns and
passes these settings to the CookieManager. The
WebTestStorageAccessManager also enables third-party cookie blocking so
that these rules will take effect.

Bug: 1096803
Change-Id: I635687e7d00cf95fa2cf54fb86e1f65a0fe85f3f
Reviewed-on: https://chromium-review.googlesource.com/2253280
WPT-Export-Revision: 35894f383d1d31327b0693c7ee5e1ed7c95a5d39

Try push failed: decision task KvPR10QwQY2VOXn8Q0DUog returned error
Attached file Notable wpt changes
# CI Results

Ran 4 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 589 tests and 1 subtests

## Status Summary

### Firefox
OK     : 189[Gecko-android-em-7.0-x86_64-debug-geckoview] 190[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 443[GitHub]
PASS   : 393[Gecko-android-em-7.0-x86_64-debug-geckoview] 394[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 396[Gecko-linux1804-64-debug] 518[GitHub]
FAIL   : 248[Gecko-linux1804-64-qr-opt] 250[Gecko-linux1804-64-debug] 251[Gecko-linux1804-64-qr-debug] 253[Gecko-android-em-7.0-x86_64-debug-geckoview] 686[GitHub]
TIMEOUT: 3[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-qr-opt] 5[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug] 90[GitHub]
ERROR  : 62[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 64[Gecko-android-em-7.0-x86_64-debug-geckoview] 106[GitHub]
NOTRUN : 2[Gecko-android-em-7.0-x86_64-debug-geckoview] 3[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug] 5[Gecko-linux1804-64-qr-opt] 142[GitHub]

### Chrome
OK     : 533
PASS   : 3234
FAIL   : 343
TIMEOUT: 39
ERROR  : 36
NOTRUN : 20

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=d241cd2a40604dcb4ee3b5637e49ce393a841e88)
[GitHub PR Head](https://wpt.fyi/results/?sha=686b31117dec01b8860aa933d81d4e82d4c3b8d4&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=686b31117dec01b8860aa933d81d4e82d4c3b8d4&label=pr_base)

## Details

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aba026d98ef6
[wpt PR 24319] - Implement Storage Access commands for TestDriver, a=testonly
https://hg.mozilla.org/integration/autoland/rev/072d37bfdacc
[wpt PR 24319] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.