Open Bug 1655754 Opened 4 years ago Updated 1 year ago

New wpt failures in / [feature-policy/picture-in-picture-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html, clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub.html, and 30 others]

Categories

(Core :: DOM: Security, defect, P3)

defect

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

Details

(Whiteboard: [wpt][domsecurity-backlog1])

Syncing wpt PR 24319 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/feature-policy/picture-in-picture-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html
Feature-Policy allow="picture-in-picture" allows same-origin navigation in an iframe.: FAIL (Chrome: PASS)
Feature-Policy allow="picture-in-picture" disallows cross-origin navigation in an iframe.: FAIL (Chrome: PASS)
/clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub.html
Feature-Policy header clipboard-write "none" disallows the top-level document.: FAIL (Chrome: PASS)
/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView.html
Tests scrollend event for scrollIntoView.: FAIL (Chrome: PASS)
Tests scrollend event for nested scrollIntoView.: FAIL (Chrome: PASS)
/clipboard-apis/async-write-blobs-read-blobs.https.html
Verify write and read clipboard (multiple types): FAIL (Chrome: PASS)
/clipboard-apis/permissions/writeText-denied.https.html
navigator.clipboard.writeText() fails when permission denied: FAIL (Chrome: PASS)
/dom/events/scrolling/overscroll-event-fired-to-window.html: ERROR (Chrome: OK)
/clipboard-apis/text-write-read/async-write-readText.https.html
Verify write and read clipboard given text: Clipboard write ([text/plain ClipboardItem) -> read text test: FAIL (Chrome: PASS)
Verify write and read clipboard given text: non-Latin1 text encoding test データ: FAIL (Chrome: PASS)
/dom/events/scrolling/overscroll-deltas.html: ERROR (Chrome: OK)
/feature-policy/picture-in-picture-disabled-by-feature-policy.https.sub.html
Feature-Policy header: picture-in-picture "none" disallows cross-origin iframes.: FAIL (Chrome: PASS)
Feature-Policy header: picture-in-picture "none" disallows same-origin iframes.: FAIL (Chrome: PASS)
Feature-Policy header: picture-in-picture "none" disallows the top-level document.: FAIL (Chrome: PASS)
/dom/events/scrolling/scrollend-event-fired-to-element-with-overscroll-behavior.html: ERROR (Chrome: OK)
/dom/events/document-level-touchmove-event-listener-passive-by-default.html: ERROR (Chrome: OK)
/clipboard-apis/async-write-image-read-image.https.html
Verify write error on malformed data [image/png ClipboardItem]: FAIL (Chrome: PASS)
Verify write and read clipboard [image/png Blob]: FAIL (Chrome: PASS)
/dom/events/scrolling/scrollend-event-fired-after-snap.html: ERROR (Chrome: OK)
/dom/events/scrolling/overscroll-event-fired-to-document.html: ERROR (Chrome: OK)
/clipboard-apis/permissions/readText-denied.https.html
navigator.clipboard.readText() fails when permission denied: FAIL (Chrome: PASS)
/feature-policy/picture-in-picture-default-feature-policy.https.sub.html
Default "picture-in-picture" feature policy [] allows cross-origin iframes.: FAIL (Chrome: PASS)
Default "picture-in-picture" feature policy [
] allows same-origin iframes.: FAIL (Chrome: PASS)
Default "picture-in-picture" feature policy [*] allows the top-level document.: FAIL (Chrome: PASS)
/clipboard-apis/feature-policy/clipboard-read/clipboard-read-enabled-on-self-origin-by-feature-policy.tentative.https.sub.html
Feature-Policy header clipboard-read "self" allows the top-level document.: FAIL (Chrome: PASS)
/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html
Tests scrollend event for calling scroll functions.: FAIL (Chrome: PASS)
Tests scrollend event for changing scroll attributes.: FAIL (Chrome: PASS)
/clipboard-apis/text-write-read/async-write-read.https.html
Verify write and read clipboard given text: Clipboard write ([text/plain ClipboardItem]) -> read ([text/plain ClipboardItem]) test: FAIL (Chrome: PASS)
Verify write and read clipboard given text: non-Latin1 text encoding test データ: FAIL (Chrome: PASS)
/clipboard-apis/detached-iframe/read-on-detaching-iframe.https.html
Verify read fails on detaching iframe: FAIL (Chrome: PASS)
/clipboard-apis/detached-iframe/writeText-readText-on-detached-iframe.https.html
Verify readText and writeText fails on detached iframe: FAIL (Chrome: PASS)
/clipboard-apis/permissions/writeText-granted.https.html
navigator.clipboard.writeText() succeeds when permission granted: FAIL (Chrome: PASS)
/clipboard-apis/detached-iframe/write-read-on-detached-iframe.https.html
Verify read and write fail on detached iframe: FAIL (Chrome: PASS)
/dom/events/scrolling/overscroll-event-fired-to-element-with-overscroll-behavior.html: ERROR (Chrome: OK)
/feature-policy/picture-in-picture-allowed-by-feature-policy.https.sub.html
Feature-Policy header: picture-in-picture * allows the top-level document.: FAIL (Chrome: PASS)
Feature-Policy header: picture-in-picture * allows cross-origin iframes.: FAIL (Chrome: PASS)
Feature-Policy header: picture-in-picture * allows same-origin iframes.: FAIL (Chrome: PASS)
/feature-policy/picture-in-picture-allowed-by-feature-policy-attribute.https.sub.html
Feature policy "picture-in-picture" can be enabled in same-origin iframe using allow="picture-in-picture" attribute: FAIL (Chrome: PASS)
Feature policy "picture-in-picture" can be enabled in cross-origin iframe using allow="picture-in-picture" attribute: FAIL (Chrome: PASS)
/clipboard-apis/text-write-read/async-writeText-read.https.html
Verify write and read clipboard given text: Clipboard write text -> read ([text/plain ClipboardItem]) test: FAIL (Chrome: PASS)
Verify write and read clipboard given text: non-Latin1 text encoding test データ: FAIL (Chrome: PASS)
/clipboard-apis/text-write-read/async-writeText-readText.https.html
Verify write and read clipboard given text: non-Latin1 text encoding test データ: FAIL (Chrome: PASS)
Verify write and read clipboard given text: Clipboard write text -> read text test: FAIL (Chrome: PASS)
/dom/events/scrolling/scrollend-event-fired-to-window.html: ERROR (Chrome: OK)
/dom/events/scrolling/scrollend-event-fired-to-document.html: ERROR (Chrome: OK)
/clipboard-apis/permissions/readText-granted.https.html
navigator.clipboard.readText() succeeds when permission granted: FAIL (Chrome: PASS)
/clipboard-apis/detached-iframe/write-on-detaching-iframe.https.html
Verify write fails on detaching iframe: FAIL (Chrome: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1647840 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Component: DOM: Core & HTML → DOM: Security

Baku, do you think we need to take a closer look at those new tests? Or can those simply be annotated as 'not working in Firefox'?

Flags: needinfo?(amarchesini)

None of these tests work on firefox because we do not expose those feature-policy directives. We should disable those tests.

Flags: needinfo?(amarchesini)
Severity: -- → S4
Priority: -- → P3
Whiteboard: [wpt] → [wpt][domsecurity-backlog1]

Hello folks, wanted to make a note here that about a few of the tests which are still failing in the hopes of getting wpts in a good shape across browsers that support scrollend as we try to ship scrollend in Chrome :) :

  • /dom/events/scrolling/scrollend-event-fired-after-snap.html
    seems to be failing because no scroll is generated from on the touch events created by the test. However, when manually tested, this works fine: a scroll is generated and scrollend fires.

There seems to be an issue with a certain test_driver API:
test_driver.Actions().scroll(x, y, dx, dy, {origin: element})
which seems to be the source of the "ValueError: Unrecognised web element" error that can be seen in the following wpts for firefox:

  • /dom/events/scrolling/overscroll-event-fired-to-document.html

  • /dom/events/scrolling/scrollend-event-fired-to-window.html
    I think there might be an issue with the way geckodriver handles {origin: element} in Actions.scroll() because it seems to be fine in chrome/chromedriver. I've tested (locally) modifying the test to use the default {origin: "viewport"} which gets the tests past the original error but still runs into a failure because no "scrollend" event is observed.
    These tests (both of which I updated recently) seem to be failing because no scrollend is fired even though scroll events are generated by the test's mousewheels. However, when I manually test the same scenario by interacting with the firefox browser, scrollend fires just fine.

  • /dom/events/scrolling/scrollend-event-for-user-scroll.html is a newer test that seems to be affected by the both of the issues mentioned above. A separate bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1826912, has already been filed for it so I'll comment there.

Finally,

  • /dom/events/scrolling/scrollend-event-not-fired-on-no-scroll.html is a newer test that seems to be affected by the test_driver.Actions().scroll(..., (origin: element)) issue.

I'll look into filing a geckodriver issue, cheers.

You need to log in before you can comment on or make changes to this bug.