1648440 - Various cleanups of dom/workers code

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Cleanup/simplify some loops in RuntimeService. r=#dom-workers-and-storage

Replace BROADCAST_ALL_WORKERS macro by a BroadcastAllWorkers member function.

Use RemoveIf instead of custom for loop.

Use range-based for where possible.

Use std::transform to transform an array into another instead of custom for loop.

Use std::copy_if for conditional copy of an array into another instead of custom for loop.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Use std::find_if and IIFE instead of custom loops in ScriptLoader. r=#dom-workers-and-storage

Depends on D81056

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Use range-based for in WorkerDebugger where possible. r=#dom-workers-and-storage

Depends on D81057

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Use range-based for in WorkerDebuggerManager. r=#dom-workers-and-storage

Depends on D81058

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Use TransformIntoNewArray and range-based for in WorkerError. r=#dom-workers-and-storage

Depends on D81059

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Use TransformIntoNewArray in RemoteWorkerChild. r=#dom-workers-and-storage

Depends on D81060

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648440 - Remove unused return value from Queue::Push. r=#dom-workers-and-storage

Depends on D81061

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c6ad132f93e
Cleanup/simplify some loops in RuntimeService. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/40cb2e9b3650
Use std::find_if and IIFE instead of custom loops in ScriptLoader. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/946bbe49fcae
Use range-based for in WorkerDebugger where possible. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/cc657f7e9008
Use range-based for in WorkerDebuggerManager. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/14e580887ae2
Use TransformIntoNewArray and range-based for in WorkerError. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/23f3be9f84e5
Use TransformIntoNewArray in RemoteWorkerChild. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/f759e3fa6b6c
Remove unused return value from Queue::Push. r=dom-workers-and-storage-reviewers,asuth

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1c6ad132f93e
https://hg.mozilla.org/mozilla-central/rev/40cb2e9b3650
https://hg.mozilla.org/mozilla-central/rev/946bbe49fcae
https://hg.mozilla.org/mozilla-central/rev/cc657f7e9008
https://hg.mozilla.org/mozilla-central/rev/14e580887ae2
https://hg.mozilla.org/mozilla-central/rev/23f3be9f84e5
https://hg.mozilla.org/mozilla-central/rev/f759e3fa6b6c