1648449 - Redesign mLoadInfos handling in ScriptLoader

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Description

[Simon Giesecke [:sg] [he/him]]

Currently, pairs of indexes and references to mLoadInfos elements are passed around, which is complex and error-prone. Essentially the index passing can be eliminated.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Use nsTArrayView for ScriptLoaderRunnable::mLoadInfos. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Stop passing around indexes to mLoadInfos. r=#dom-workers-and-storage

Depends on D81068

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Use range-based for for iterating mLoadInfos. r=#dom-workers-and-storage

Depends on D81069

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Pass Span instead of indexes to ScriptExecutorRunnable. r=#dom-workers-and-storage

Depends on D81070

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Remove intermediate conversion from iterators to indexes. r=#dom-workers-and-storage

Depends on D81072

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Use TransformIntoNewArray in Load. r=#dom-workers-and-storage

Depends on D81073

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Use NotNull for CacheCreator::mLoaders. r=#dom-workers-and-storage

Depends on D81075

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1648449 - Improve variable naming and comments related to script scheduling. r=#dom-workers-and-storage,asuth

Depends on D81068

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a0390cd1a1
Use nsTArrayView for ScriptLoaderRunnable::mLoadInfos. r=dom-workers-and-storage-reviewers,asuth

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a1a0390cd1a1

Comment 11

[Takanori MATSUURA]

"leave-open" missing?

Comment 12

[Simon Giesecke [:sg] [he/him]]

(In reply to Takanori MATSUURA from comment #11)

"leave-open" missing?

Yes, thanks! (I removed it again now since I am now landing the remaining patches. I somehow accidentally landed the first one separately yesterday).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54bee02abda4
Improve variable naming and comments related to script scheduling. r=asuth,dom-workers-and-storage-reviewers
https://hg.mozilla.org/integration/autoland/rev/a99208767bc1
Stop passing around indexes to mLoadInfos. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/d174dd6c2822
Use range-based for for iterating mLoadInfos. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/9ac5934bdea1
Pass Span instead of indexes to ScriptExecutorRunnable. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/ae9b646341ae
Remove intermediate conversion from iterators to indexes. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/1ebae06069e7
Use TransformIntoNewArray in Load. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/e5b9c33679ef
Use NotNull for CacheCreator::mLoaders. r=dom-workers-and-storage-reviewers,asuth

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/54bee02abda4
https://hg.mozilla.org/mozilla-central/rev/a99208767bc1
https://hg.mozilla.org/mozilla-central/rev/d174dd6c2822
https://hg.mozilla.org/mozilla-central/rev/9ac5934bdea1
https://hg.mozilla.org/mozilla-central/rev/ae9b646341ae
https://hg.mozilla.org/mozilla-central/rev/1ebae06069e7
https://hg.mozilla.org/mozilla-central/rev/e5b9c33679ef