1648464 - Add a way to trigger the encoding detector from the menu

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

Add an item "Automatic" to the encoding menu such that it triggers the detector with TLD ignored and UTF-8 allowed as an outcome.

Add associated telemetry.

(The expectation is that telemetry will show that this menu item can replace the character encoding menu itself in the future.)

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1648464 - Add an Autodetect item to the Text Encoding menu.

Comment 4

[Henri Sivonen (:hsivonen)]

Tested with:

https://hsivonen.com/test/moz/charset-menu/
https://hsivonen.com/test/moz/charset/
https://hsivonen.com/test/charset/

(Obviously, x-mac-cyrillic isn't supported by chardetng, so breaking that one is expected. Also, ISO-2022-JP declared as UTF-8 is, by design, unoverridable.)

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c4a5f5b1f0337edf6d235cc0b30f979234eeb1b

Comment 6

[Henri Sivonen (:hsivonen)]

Attachment: Date review

Comment 7

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a057b73604b10b173daabff6860d6e7f83c7aab

Comment 8

[Chris H-C :chutten]

Comment on attachment 9196561 [details]
Date review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 91.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :hsivonen is responsible for renewing or removing the collection before it expires in Firefox 91.

---

Result: datareview+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a6b398a95b
Add an Autodetect item to the Text Encoding menu. r=emk,chutten,Gijs

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a8a6b398a95b