1648534 - On screen keyboard no longer appears when tapping in text fields (Surface)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Asif Youssuff]

From https://www.reddit.com/r/firefox/comments/hfb0u6/surface_touch_keyboard/

the touch keyboard no longer pops up automatically when I touch a text field. I looked in the options, and as far as I can tell I have it enabled. The keyboard still pops up normally in other applications, so it seems to be isolated to Firefox.

Comment 1

[Asif Youssuff]

Attachment: about:support

Comment 2

[Makoto Kato [:m_kato]]

What value of ui.osk.debug.keyboardDisplayReason in about:config when this occurs?

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1618759

Comment 4

[Asif Youssuff]

The user says the value of ui.osk.debug.keyboardDisplayReason is:

AIOSKIDM: failed reading value of regkey.

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Asif Youssuff from comment #4)

The user says the value of ui.osk.debug.keyboardDisplayReason is:

AIOSKIDM: failed reading value of regkey.

Thanks. Before my landing, firefox's software keyboard code doesn't work on Windows 10 RS1+. So TSF automatically open software keyboard instead.

Hmm, Firefox looks the following settings.
https://www.windowscentral.com/auto-display-touch-keyboard-windows-10-desktop-mode

So what setting of ""Automatically show the touch keyboard in windowed apps when there's no keyboard attached to your device."? If you turn on/off this, is software keyboard opened?

Comment 6

[Makoto Kato [:m_kato]]

• If tablet mode, software keyboard is opened.
• If "Automatically show the touch keyboard in windowed apps when there's no keyboard attached to your device." is on even if not table mode, software keyboard is opened.

Comment 7

[Asif Youssuff]

Attachment: sqN4D3D.png

User says:

My settings doesn't have that exactly. Here is what it looks like (screenshot attached)

However, unchecking and rechecking that option seems to have fixed the bug! The keyboard is behaving normal again in Firefox.

Comment 8

[Makoto Kato [:m_kato]]

Thanks. I think that bug 1197722 is not enough to fix it.

Comment 9

[Makoto Kato [:m_kato]]

Although I don't have table device that runs on 2004, EnableDesktopModeAutoInvok is changed.

Before 2004 such as 1909

if EnableDesktopModeAutoInvok is nothing, it is off.

2004

If EnableDesktopModeAutoInvok is nothing, it is on. (This verified by my ASUS's ARM64 Windows touch device, not table).

Comment 10

[Makoto Kato [:m_kato]]

I set up tablet PC again.

(In reply to Makoto Kato [:m_kato] from comment #9)

2004

If EnableDesktopModeAutoInvok is nothing, it is on. (This verified by my ASUS's ARM64 Windows touch device, not table).

This is incorrect. EnableDesktopModeAutoInvoke is used in both HKCU and HKLM. So we need read HKLM too. Fix is coming.

Comment 11

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1db33b05c53bbc8e79050e1a8f7ddff8bc8fa28b

Comment 13

[Makoto Kato [:m_kato]]

Attachment: Bug 1648534 - Read HKLM's EnableDesktopModeAutoInvoke entry if no entry in HKCU. r=masayuki

This is regression by bug 1618759 and bug 1197722.

By bug 1197722, we use registry value whether opening software keyboard even if
desktop mode. But this fix isn't enough.

Also, before landing bug 1618759, since TSF manages software keyboard state on
newer Windows 10 version such as Windows 10 RS1, bug 1197722's fix isn't used.
Then, after landing bug 1618759, since we use EnableDesktopModeAutoInvoke
again, this issue occurs.

Since EnableDesktopModeAutoInvoke is available if in HKLM, we should read
HKLM's key too.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8636b6b1f95f
Read HKLM's EnableDesktopModeAutoInvoke entry if no entry in HKCU. r=masayuki

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8636b6b1f95f

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this something we should eventually backport to ESR78?

Comment 17

[Makoto Kato [:m_kato]]

Comment on attachment 9163458 [details]
Bug 1648534 - Read HKLM's EnableDesktopModeAutoInvoke entry if no entry in HKCU. r=masayuki

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is regression by bug 1618759 and bug 1197722. Original code was added by bug 1197722, but it didn't work on Windows 10 RS1+ to manage software keyboard. So although I had fixed it by bug 1618759, It caused another issue that we didn't read system setting well.
• User impact if declined: When user set the registry entry of "Automatically show the touch keyboard in windowed apps when there's no keyboard attached to your device." for system, not user, we don't check this value. So software keyboard isn't shown up even if this setting is turned on.
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reading registry entry value additional to HKEY_LOCAL_MACHINE (system).
• String or UUID changes made by this patch: no

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9163458 [details]
Bug 1648534 - Read HKLM's EnableDesktopModeAutoInvoke entry if no entry in HKCU. r=masayuki

Approved for 78.3esr.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/086a2f020fc9