1648545 - Separate SpecialPowers code from the "Special Powers" extension

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[u608768]

The code living in testing/specialpowers/content should be bundled separately from the SpecialPowers extension.

This would make it so we could still use the extension to load the testing-common stuff in mochitest, and then load SpecialPowers manually in xpcshell when needed.

Comment 1

[u608768]

This no longer blocks bug 1580811, but we may still need SpecialPowers for xpcshell tests in the future.

Comment 2

[Neha Kochar [:neha]]

Not blocking any Fission work.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1648545: Part 1 - Move most of SpecialPowers to testing-common. r=mccr8

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1648545: Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1648545: Part 3 - Support Assert in SpecialPowers.spawn for xpcshell tests. r=mccr8

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1648545: Part 4 - Move ContentPage.spawn to use SpecialPowers rather than ContentTask. r=mccr8

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Nick Alexander :nalexander [he/him]]

Clearing NI since I'm not going to land this myself.

Comment 9

[Andrew Halberstadt [:ahal]]

Bumping up the needinfo here, do we still want these patches?

Comment 10

[Kris Maglione [:kmag]]

Oh, I didn't realize this hadn't landed

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca7abd873d1
Part 1 - Move most of SpecialPowers to testing-common. r=ahal
https://hg.mozilla.org/integration/autoland/rev/652b48b10d37
Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/f63760c845f3
Part 3 - Support Assert in SpecialPowers.spawn for xpcshell tests. r=ahal
https://hg.mozilla.org/integration/autoland/rev/ac3d639547fa
Part 4 - Move ContentPage.spawn to use SpecialPowers rather than ContentTask. r=ahal

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1648545) for causing mass failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ac3d639547fa1f1567cca68455df4a67733e56d3&selectedTaskRun=C1FbxLmdTguRF4Xxpp9fWg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=417085983&repo=autoland&lineNumber=5567
https://treeherder.mozilla.org/logviewer?job_id=417086601&repo=autoland&lineNumber=5468
https://treeherder.mozilla.org/logviewer?job_id=417086608&repo=autoland&lineNumber=3577
https://treeherder.mozilla.org/logviewer?job_id=417082616&repo=autoland&lineNumber=15393
https://treeherder.mozilla.org/logviewer?job_id=417086723&repo=autoland&lineNumber=11958
https://treeherder.mozilla.org/logviewer?job_id=417090336&repo=autoland&lineNumber=8768
TV: https://treeherder.mozilla.org/logviewer?job_id=417083706&repo=autoland&lineNumber=2360

Backout: https://hg.mozilla.org/integration/autoland/rev/f5a6bb91d4b7b5eeefa2fab0c1f91b3c50bc34ae

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc09c886ada7
Part 1 - Move most of SpecialPowers to testing-common. r=ahal,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/8dc935134f45
Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/392ab0f83b59
Part 3 - Support Assert in SpecialPowers.spawn for xpcshell tests. r=ahal,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/f950f72d59e2
Part 4 - Move ContentPage.spawn to use SpecialPowers rather than ContentTask. r=ahal,cookie-reviewers,anti-tracking-reviewers,timhuang

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cc09c886ada7
https://hg.mozilla.org/mozilla-central/rev/8dc935134f45
https://hg.mozilla.org/mozilla-central/rev/392ab0f83b59
https://hg.mozilla.org/mozilla-central/rev/f950f72d59e2

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d445d47adf44
adjust Thunderbird code for move of most of SpecialPowers to testing-common. rs=bustage-fix