1580811 - Add support for testing fission OOP iframes in xpcshell tests

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Tomislav Jovanovic :zombie]

Currently the largest part of extension APIs are tested via xpcshell tests, simulating content loads via windowless browsers:

https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionXPCShellUtils.jsm#175
https://searchfox.org/mozilla-central/search?q=loadContentPage&path=components%2Fextensions

Unfortunately, running that with Fission iframes currently doesn't work, since part of our process switching logic is in browser code.

We should fix this, instead of moving all our tests (back) to other, less efficient test suites like mochitest.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Chris Peterson [:cpeterson]]

Blocks enabling Fission in Nightly (M6)

Comment 4

[Chris Peterson [:cpeterson]]

Tracking for Fission M6a

Depends on DocumentLoadListener bug 1636169

Comment 5

[u608768]

Attachment: Bug 1580811 - Take chrome flags instead of a boolean in nsIAppShellService::createWindowlessBrowser, r?nika

This makes it easier for callers to set LoadContext fields on the new
BrowsingContext.

Comment 6

[u608768]

Attachment: Bug 1580811 - Make the ContentPage browser work with out-of-process frames, r?nika,zombie

Depends on D80083

Comment 7

[u608768]

Attachment: Bug 1580811 - Add xpcshell test to check that moz-extension: redirect by webRequest is loaded in the correct process, r=zombie

Originally authored by :willdurand for bug 1573456.

TODO: Mention why/how bug 1637869 fixed this.
TODO: This still fails when we run with e10s/remote?

Comment 8

[u608768]

Attachment: Bug 1580811 - Add xpcshell test to check that we process-switch cross-origin frames, r?zombie

Depends on D80084

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9c8318e3c01
Make the ContentPage browser work with out-of-process frames, r=nika,zombie
https://hg.mozilla.org/integration/autoland/rev/d18f8e821cc7
Add xpcshell test to check that we process-switch cross-origin frames, r=zombie
https://hg.mozilla.org/integration/autoland/rev/7733de7d4f5a
Add xpcshell test to check that moz-extension: redirect by webRequest is loaded in the correct process, r=zombie

Comment 11

[Atila Butkovits]

Backed outfor failures at test_ext_contentscript_xorigin_frame.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/995be63e7ebdb447a9aad11155a4d62d3284e3dd

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7733de7d4f5a4b241637550b741eae96f8cefc99&searchStr=x5&selectedTaskRun=KcqHDDIzTuK27lOGrLpPLg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309220918&repo=autoland&lineNumber=1863

Comment 12

[u608768]

Bug 1580764 made it so we use BrowsingContext IDs rather than window IDs to compute frame IDs. The new test is still checking the window ID.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bfd6bae286a
Make the ContentPage browser work with out-of-process frames, r=nika,zombie
https://hg.mozilla.org/integration/autoland/rev/85ca6cff7dfb
Add xpcshell test to check that we process-switch cross-origin frames, r=zombie
https://hg.mozilla.org/integration/autoland/rev/4e9d6619c9d5
Add xpcshell test to check that moz-extension: redirect by webRequest is loaded in the correct process, r=zombie

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0bfd6bae286a
https://hg.mozilla.org/mozilla-central/rev/85ca6cff7dfb
https://hg.mozilla.org/mozilla-central/rev/4e9d6619c9d5