1648679 - Crash on start-up due to bug 1626362

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Bug 1626362 (more specifically this change) changed nsIDocShell.useErrorPages, which we use. Thunderbird now crashes on start-up.

I'm going to comment out the two lines causing the crash, so we can at least get some tests running.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c29a908bc582
Temporarily prevent start-up crash caused by bug 1626362. rs=bustage-fix

Comment 2

[Geoff Lankow (:darktrojan)]

So what do we do now, Matt?

Comment 3

[Matt Woodrow (:mattwoodrow)]

What exactly is the crash here?

Is it the CheckOnlyEmbedderCanSet assert?

Comment 4

[Geoff Lankow (:darktrojan)]

It's at mozilla::dom::syncedcontext::Transaction<mozilla::dom::BrowsingContext>::Commit(mozilla::dom::BrowsingContext*)

Here's a sample log I should've provided before: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307624693&repo=comm-central&lineNumber=893

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1648679 - Allow setting UseErrorPages from the parent process. r?nika

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a32b5c889735
Allow setting UseErrorPages from the parent process. r=nika

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a32b5c889735

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcc99ba3b9a1
Backed out changeset c29a908bc582. rs=backout DONTBUILD

Comment 9

[Geoff Lankow (:darktrojan)]

Thank you Matt!

Comment 10

[Wayne Mery (:wsmwk)]

Thanks. esr78 is also affected - being discussed in bug 1626362.

Comment 11

[Geoff Lankow (:darktrojan)]

Bug 1626362 was wontfixed for 78.