Closed Bug 1648824 Opened 3 months ago Closed 3 months ago

Fix build dependency for FrameClasses.py (to fix incremental rebuild errors such as "no member named 'SVGImageFrame_id' in 'nsQueryFrame'")

Categories

(Core :: Layout, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

I got build error like bug 1648463 comment 4.

I think we'll need to set 'inputs' [1] argument to [2] so that whenever FrameClasses.py is changed, the build system re-runs GenerateFrameLists.py

[1] https://firefox-source-docs.mozilla.org/build/buildsystem/mozbuild-symbols.html#generated-files
[2] https://searchfox.org/mozilla-central/rev/8118a1f3390b232e70497770d372de062e44dd5f/layout/generic/moz.build#237-242

GenerateFrameLists.py uses FrameClasses.py as an input so that whenever
FrameClasses.py is changed, the build system re-runs
GenerateFrameLists.py.

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4f190e90ee8f
Set correct build dependency for FrameClasses.py. r=jwatt
Summary: Fix build dependency for FrameClasses.py → Fix build dependency for FrameClasses.py (to fix incremental rebuild errors such as "no member named 'SVGImageFrame_id' in 'nsQueryFrame'")
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.