1649073 - Crash in [@ gfxDWriteFontList::AppendFamiliesFromCollection]

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-f5a000e2-019b-4ff5-a18a-aeb780200627.

Top 10 frames of crashing thread:

0 xul.dll gfxDWriteFontList::AppendFamiliesFromCollection gfx/thebes/gfxDWriteFontList.cpp:1034
1 xul.dll gfxDWriteFontList::InitSharedFontListForPlatform gfx/thebes/gfxDWriteFontList.cpp:1325
2 xul.dll gfxPlatformFontList::InitFontList gfx/thebes/gfxPlatformFontList.cpp:483
3 xul.dll gfxWindowsPlatform::CreatePlatformFontList gfx/thebes/gfxWindowsPlatform.cpp:558
4 xul.dll static gfxPlatform::Init gfx/thebes/gfxPlatform.cpp:990
5 xul.dll static gfxPlatform::GetPlatform gfx/thebes/gfxPlatform.cpp:509
6 xul.dll static nsUXThemeData::UpdateTitlebarInfo widget/windows/nsUXThemeData.cpp:171
7 xul.dll nsWindow::Create widget/windows/nsWindow.cpp:1003
8 xul.dll nsIWidget::Create widget/nsIWidget.h:461
9 xul.dll mozilla::AppWindow::Initialize xpfe/appshell/AppWindow.cpp:221

This seems to have started with buildid 20200626094540. There's only four nightly crashes on file but they come from two different users and the stack are consistent. It might be worth noting that both of them are on Windows 7; one using a 32-bit build and the other a 64-bit one.

Comment 1

[Jonathan Kew [:jfkthame]]

Looks like GetSystemFontCollection must have failed for these users; we need to check for that and bail out of the initialization here.

Comment 2

[Jonathan Kew [:jfkthame]]

Jeff, did anything come of the attempt to get insight into cases where DirectWrite initialization fails (eg bug 1619978, bug 1638331)? It looks like the crashes here must be examples where GetSystemFontCollection returned null for some reason.

(I'll add error-handling in gfxDWriteFontList::InitSharedFontListForPlatform to avoid this crash, but that presumably will mean these users fall back to the GDI font backend again, which isn't great.)

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1649073 - Bail out of InitSharedFontListForPlatform if we fail to get the dwrite system font collection. r=jwatt

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jonathan Kew (:jfkthame) from comment #2)

Jeff, did anything come of the attempt to get insight into cases where DirectWrite initialization fails (eg bug 1619978, bug 1638331)? It looks like the crashes here must be examples where GetSystemFontCollection returned null for some reason.

Nope, it doesn't look like we've had any of the injected crashes yet.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33c104d5c335
Bail out of InitSharedFontListForPlatform if we fail to get the dwrite system font collection. r=jwatt

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/33c104d5c335