1649522 - Deprecate Master Password; Replace with Primary Password

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Betsy Mikel [:betsymi]]

The term "master" in software makes reference to the "Master/Slave" relationship. As one action to uproot this problematic terminology (see Meta bug), we are replacing the term Master Password with Primary Password.

See Transvision for instances of where this term appears in Thunderbird.

Comment 1

[Magnus Melin [:mkmelin]]

Seems we have fairly few cases in mail.
https://searchfox.org/comm-central/rev/e3ec4fdf727ca65e4acbe42fc4888275977eaf5a/mail/locales/en-US/messenger/preferences/preferences.ftl#133-145,681-689 and
https://searchfox.org/comm-central/rev/e3ec4fdf727ca65e4acbe42fc4888275977eaf5a/mail/locales/en-US/chrome/messenger/preferences/preferences.properties#112

Remember the localization key needs to be replaced.
I think the properties change should just involve moving that part to Fluent instead.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1649522-master-to-primary-password.patch

I have already a patch.
This is a port of https://hg.mozilla.org/mozilla-central/rev/39f3cb77e407

In Use a Primary Password I'm using uppercase like in FX, which also makes more sense as it is used everywhere uppercase.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9164702 [details] [diff] [review]
1649522-master-to-primary-password.patch

Review of attachment 9164702 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, do you want to move pw_change2empty_in_fips_mode to Fluent as well?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1649522-master-to-primary-password.patch

Moved pw_change2empty_in_fips_mode to fluent. I can't test FIPS and check if my changes work.

I've done it like https://searchfox.org/mozilla-central/rev/b2395478c6adf6e5b241be1610fb1d920ed995ed/browser/components/preferences/privacy.js#2025-2028.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9164722 [details] [diff] [review]
1649522-master-to-primary-password.patch

Review of attachment 9164722 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cde209054da5
Port bug 1649522: Deprecate Master Password; Replace with Primary Password. r=mkmelin