Closed Bug 1649522 Opened 1 month ago Closed 23 days ago

Deprecate Master Password; Replace with Primary Password

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr78 unaffected, thunderbird79 unaffected)

RESOLVED FIXED
Thunderbird 80.0
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird79 --- unaffected

People

(Reporter: betsymi, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

The term "master" in software makes reference to the "Master/Slave" relationship. As one action to uproot this problematic terminology (see Meta bug), we are replacing the term Master Password with Primary Password.

See Transvision for instances of where this term appears in Thunderbird.

Assignee: nobody → lasana
Duplicate of this bug: 1653966

I have already a patch.
This is a port of https://hg.mozilla.org/mozilla-central/rev/39f3cb77e407

In Use a Primary Password I'm using uppercase like in FX, which also makes more sense as it is used everywhere uppercase.

Assignee: lasana → richard.marti
Status: NEW → ASSIGNED
Attachment #9164702 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9164702 [details] [diff] [review]
1649522-master-to-primary-password.patch

Review of attachment 9164702 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, do you want to move pw_change2empty_in_fips_mode to Fluent as well?
Attachment #9164702 - Flags: review?(mkmelin+mozilla) → review+

Moved pw_change2empty_in_fips_mode to fluent. I can't test FIPS and check if my changes work.

I've done it like https://searchfox.org/mozilla-central/rev/b2395478c6adf6e5b241be1610fb1d920ed995ed/browser/components/preferences/privacy.js#2025-2028.

Attachment #9164702 - Attachment is obsolete: true
Attachment #9164722 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9164722 [details] [diff] [review]
1649522-master-to-primary-password.patch

Review of attachment 9164722 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin
Attachment #9164722 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 80.0
Type: enhancement → task

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cde209054da5
Port bug 1649522: Deprecate Master Password; Replace with Primary Password. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.