1649545 - Upgrade Firefox 80 to use NSS 3.55

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Kevin Jacobs [:kjacobs]]

Tracking NSS 3.55 for Firefox 80. Ultimate tag will be NSS_3_55_RTM.

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1649545 - land NSS 58c2abd7404e UPGRADE_NSS_RELEASE, r=jcj

2020-06-26 Kevin Jacobs <[e-mail]>

* automation/abi-check/expected-report-libssl3.so.txt, automation/abi-
check/previous-nss-release, lib/nss/nss.h, lib/softoken/softkver.h,
lib/util/nssutil.h:
Set version numbers to 3.55 beta
[332ab7db68ba]

2020-06-25 Kevin Jacobs <[e-mail]>

* tests/all.sh:
Bug 1649190 - Run cipher, sdr, and ocsp tests under standard test
cycle.
[f373809abfc0]

2020-06-15 Kevin Jacobs <[e-mail]>

    * gtests/common/testvectors/p256ecdsa-sha256-vectors.h,
    gtests/common/testvectors/p384ecdsa-sha384-vectors.h,
    gtests/common/testvectors/p521ecdsa-sha512-vectors.h,
    gtests/common/testvectors_base/test-structs.h,
    gtests/common/wycheproof/genTestVectors.py,
    gtests/pk11_gtest/pk11_ecdsa_unittest.cc:
    Bug 1649226 - Add Wycheproof ECDSA tests.
    [41292ff7f545]

2020-06-30 Benjamin Beurdouche <[e-mail]>

* lib/pkcs12/p12d.c:
Bug 1649322 - Fix null pointer passed as argument in
pk11wrap/pk11pbe.c:1246 r=kjacobs
[cc43ebf5bf88]

2020-06-30 Danh <[e-mail]>

* coreconf/arch.mk, coreconf/config.mk, lib/freebl/Makefile:
Bug 1646594 - Enable AVX2 if applicable on x86_64 with make 4.3
r=bbeurdouche
[b579895aceb0]

2020-07-02 Benjamin Beurdouche <[e-mail]>

* lib/ssl/ssl3con.c:
Bug 1649316 - Prevent memcmp to be called with a zero length in
ssl/ssl3con.c:6621 r=kjacobs
[8fe9213d0551]

2020-07-02 Alexander Scheel <[e-mail]>

* lib/cryptohi/secvfy.c:
Bug 1649487 - Fix bad assert in VFY_EndWithSignature. r=jcj
[c9438b528103]

2020-07-06 Dana Keeler <[e-mail]>

* automation/abi-check/expected-report-libnss3.so.txt,
gtests/pk11_gtest/pk11_find_certs_unittest.cc, lib/nss/nss.def,
lib/pk11wrap/pk11cert.c, lib/pk11wrap/pk11pub.h:
Bug 1649633 - add PK11_FindEncodedCertInSlot r=kjacobs,jcj

PK11_FindEncodedCertInSlot can be used to determine the PKCS#11
object handle of an encoded certificate in a given slot. If the
given certificate does not exist in that slot, CK_INVALID_HANDLE is
returned.
[32fe710a942f]

* gtests/pk11_gtest/pk11_find_certs_unittest.cc:
Bug 1649633 - follow-up to make test comparisons in
pk11_find_certs_unittest.cc yoda comparisons r=kjacobs
[424dae31a1c1]

2020-07-07 Kevin Jacobs <[e-mail]>

    * gtests/pk11_gtest/pk11_rsapkcs1_unittest.cc, lib/freebl/rsapkcs.c:
    Bug 1067214 - Check minimum padding in RSA_CheckSignRecover.
    r=rrelyea

    This patch adds a check to `RSA_CheckSignRecover` enforcing a
    minimum padding length of 8 bytes for PKCS #1 v1.5-formatted
    signatures. In practice, RSA key size requirements already ensure
    this requirement is met, but smaller (read: broken) key sizes can be
    used via configuration overrides, and NSS should just follow the
    spec.
    [e5324bd5a885]

2020-07-08 Kevin Jacobs <[e-mail]>

    * gtests/ssl_gtest/libssl_internals.c,
    gtests/ssl_gtest/libssl_internals.h,
    gtests/ssl_gtest/ssl_record_unittest.cc,
    gtests/ssl_gtest/tls_agent.cc, gtests/ssl_gtest/tls_agent.h,
    lib/ssl/dtls13con.c, lib/ssl/dtls13con.h, lib/ssl/ssl3con.c,
    lib/ssl/ssl3prot.h, lib/ssl/sslspec.h, lib/ssl/sslt.h,
    lib/ssl/tls13con.c, lib/ssl/tls13exthandle.c:
    Bug 1647752 - Update DTLS 1.3 implementation to draft-38. r=mt

    This patch updates DTLS 1.3 to draft-38. Specifically:

     # `ssl_ct_ack` value changes from 25 to 26. # AEAD limits in
    `tls13_UnprotectRecord` enforce a maximum of 2^36-1 (as we only
    support GCM/ChaCha20 AEADs) decryption failures before the
    connection is closed. # Post-handshake authentication will no longer
    be negotiated in DTLS 1.3. This allows us to side-step the more
    convoluted state machine requirements.
    [132a87fc8689]

2020-07-09 Benjamin Beurdouche <[e-mail]>

    * lib/pk11wrap/pk11pbe.c, lib/pkcs12/p12d.c:
    Bug 1649322 - Fix null pointer passed as argument in
    pk11wrap/pk11pbe.c:1246 r=kjacobs

    This is a fixup patch that reverts https://hg.mozilla.org/projects/n
    ss/rev/cc43ebf5bf88355837c5fafa2f3c46e37626707a and adds a null
    check around the memcpy in question.
    [80bea0e22b20]

2020-07-09 J.C. Jones <[e-mail]>

    * lib/softoken/pkcs11.c:
    Bug 1651520 - slotLock race in NSC_GetTokenInfo r=kjacobs

    Basically, NSC_GetTokenInfo doesn't lock slot->slotLock before
    accessing slot after obtaining it, even though slotLock is defined
    as its lock. [0]

    [0] https://searchfox.org/nss/rev/a412e70e55218aaf670f1f10322fa734d8
    a9fbde/lib/softoken/pkcs11i.h#320-321
    [58c2abd7404e] [tip]

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06be9b59deb0
land NSS 58c2abd7404e UPGRADE_NSS_RELEASE, r=jcj

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/06be9b59deb0

Comment 4

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1649545 - land NSS ca068f5b5c17 UPGRADE_NSS_RELEASE, r=jcj

2020-07-16 Billy Brumley <[e-mail]>

* lib/freebl/ecl/ecl-priv.h, lib/freebl/ecl/ecl.c,
lib/freebl/ecl/ecp_secp521r1.c, lib/freebl/freebl_base.gypi,
lib/freebl/manifest.mn:
Bug 1631583 - ECC: constant time P-521 r=kjacobs,rrelyea,bbeurdouche

This portable code contributed by the Network and Information
Security Group (NISEC) at Tampere University comes from:

[ECCKiila](https://gitlab.com/nisec/ecckiila) that uses
[Fiat](https://github.com/mit-plv/fiat-crypto) for the underlying
field arithmetic.

Co-authored-by: Luis Rivera-Zamarripa <[e-mail]>
Co-authored-by: Jesús-Javier Chi-Domínguez
<[e-mail]>

[ca068f5b5c17] [tip]

* lib/freebl/ecl/ecl-priv.h, lib/freebl/ecl/ecl.c,
lib/freebl/ecl/ecp_secp384r1.c, lib/freebl/freebl_base.gypi,
lib/freebl/manifest.mn, tests/ec/ectest.sh:
Bug 1631583 - ECC: constant time P-384 r=bbeurdouche,rrelyea

This portable code contributed by the Network and Information
Security Group (NISEC) at Tampere University comes from:

[ECCKiila](https://gitlab.com/nisec/ecckiila) that uses
[Fiat](https://github.com/mit-plv/fiat-crypto) for the underlying
field arithmetic.

Co-authored-by: Luis Rivera-Zamarripa <[e-mail]>
Co-authored-by: Jesús-Javier Chi-Domínguez
<[e-mail]>

[d19a3cd451bb]

2020-07-13 Robert Relyea <[e-mail]>

* lib/pk11wrap/pk11pub.h:
Bug 1643528 Cannot compile code with nss headers and -Werror=strict-
prototypes r=kjacobs
[01ffd8fef7fa]

2020-07-10 Daiki Ueno <[e-mail]>

* gtests/ssl_gtest/ssl_auth_unittest.cc, lib/ssl/ssl3con.c,
lib/ssl/ssl3exthandle.c, lib/ssl/sslimpl.h,
lib/ssl/tls13exthandle.c:
Bug 1646324, advertise rsa_pkcs1_* schemes in CH and CR for certs,
r=mt

Summary: In TLS 1.3, unless "signature_algorithms_cert" is
advertised, the "signature_algorithms" extension is used as an
indication of supported algorithms for signatures on certificates.
While rsa_pkcs1_* signatures schemes cannot be used for signing
handshake messages, they should be advertised if the peer wants to
to support certificates signed with RSA PKCS#1.

This adds a flag to ssl3_EncodeSigAlgs() and ssl3_FilterSigAlgs() to
preserve rsa_pkcs1_* schemes in the output.

Reviewers: mt

Reviewed By: mt

Bug #: 1646324

[df1d2695e115]

2020-07-09 Benjamin Beurdouche <[e-mail]>

* gtests/pk11_gtest/pk11_pbkdf2_unittest.cc, lib/pk11wrap/pk11pbe.c:
Bug 1649648 - Fix null pointers passed as argument in
pk11wrap/pk11pbe.c:886 r=kjacobs

[de661583d467]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfbde1e7984a
land NSS ca068f5b5c17 UPGRADE_NSS_RELEASE, r=jcj

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bfbde1e7984a

Comment 7

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1649545 - land NSS 615362dff5ad UPGRADE_NSS_RELEASE, r=jcj

2020-07-18 Benjamin Beurdouche <[e-mail]>

* gtests/pk11_gtest/pk11_cipherop_unittest.cc, lib/softoken/pkcs11c.c:
Bug 1636771 - Disable PKCS11 incremental mode for ChaCha20.
r=kjacobs,rrelyea

Depends on D74801

[615362dff5ad] [tip]

* gtests/pk11_gtest/pk11_chacha20poly1305_unittest.cc,
lib/freebl/chacha20poly1305.c:
Bug 1636771 - Fix incorrect call to Chacha20Poly1305 by PKCS11.
r=jcj,kjacobs,rrelyea

[a5e82e40f03e]

2020-07-16 Benjamin Beurdouche <[e-mail]>

* lib/softoken/pkcs11c.c:
Bug 1637222 - Enforce IV length check for DES. r=kjacobs,jcj

[0c70232cb6d3]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baf73b70e5c0
land NSS 615362dff5ad UPGRADE_NSS_RELEASE, r=jcj

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/baf73b70e5c0

Comment 10

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1649545 - land NSS NSS_3_55_BETA1 UPGRADE_NSS_RELEASE, r=jcj

2020-07-21 Benjamin Beurdouche <[e-mail]>

* cmd/bltest/blapitest.c:
Bug 1653202 - Fix issue disabling other mechanisms when SEED is
deprecated in cmd/bltest/blapitest.c. r=kjacobs

[0768baa431e7] [NSS_3_55_BETA1]

2020-07-21 Kevin Jacobs <[e-mail]>

* automation/release/nspr-version.txt:
Bug 1652331 - NSS 3.55 should depend on NSPR 4.27. r=kaie

[3deefc218cd9]

2020-07-20 Billy Brumley <[e-mail]>

* lib/freebl/ec.c:
Bug 1631573: Remove unnecessary scalar padding in ec.c
r=kjacobs,bbeurdouche

Subsequent calls to ECPoints_mul and ECPoint_mul remove this
padding.

Timing attack countermeasures are now applied more generally deeper
in the call stack.

[aeb2e583ee95]

2020-07-20 Kai Engert <[e-mail]>

* lib/nss/nssinit.c:
Bug 1653310 - On macOS check if nssckbi exists prior to loading it.
r=kjacobs

[ca207655b4b7]

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d376ee46c0f1
land NSS NSS_3_55_BETA1 UPGRADE_NSS_RELEASE, r=jcj

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d376ee46c0f1

Comment 13

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1649545 - land NSS NSS_3_55_RTM UPGRADE_NSS_RELEASE, r=keeler

2020-07-24 J.C. Jones <[e-mail]>

* lib/nss/nss.h, lib/softoken/softkver.h, lib/util/nssutil.h:
Set version numbers to 3.55 final
[6705eec655c8] [NSS_3_55_RTM] <NSS_3_55_BRANCH>

2020-07-22 Kai Engert <[e-mail]>

* lib/nss/nssinit.c:
Bug 1653310 - Backed out changeset ca207655b4b7, because with
updated NSPR this workaround is no longer required. r=kjacobe
[a448fe36e58b]

2020-07-21 Kevin Jacobs <[e-mail]>

* .hgtags:
Added tag NSS_3_55_BETA1 for changeset 0768baa431e7
[2572e14f17d6]

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12870b9169ab
land NSS NSS_3_55_RTM UPGRADE_NSS_RELEASE, r=keeler

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/12870b9169ab