1649611 - DownloadIntegration.jsm imports OS.File during startup

Status: RESOLVED FIXED

(Toolkit :: OS.File, task)

Description

[Barret Rennie [:barret] (they/them)]

According to this startup profile, DownloadIntegration.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::ipc::MessageChannel::MessageTask::Run() [libxul.so]
mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [libxul.so]
mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) [libxul.so]
PBackgroundIDBRequest::Msg___delete__ []
mozilla::dom::indexedDB::PBackgroundIDBRequestChild::OnMessageReceived(IPC::Message const&) [libxul.so]
mozilla::dom::indexedDB::BackgroundRequestChild::Recv__delete__(mozilla::dom::indexedDB::RequestResponse&&) [libxul.so]
IndexedDB:SetResultAndDispatchSuccessEvent []
mozilla::dom::indexedDB::BackgroundRequestChild::HandleResponse(mozilla::dom::indexedDB::SerializedStructuredCloneReadInfo&&) [libxul.so]
mozilla::dom::indexedDB::(anonymous namespace)::detail::DispatchSuccessEvent(RefPtr<mozilla::dom::IDBRequest> const&, mozilla::SafeRefPtr<mozilla::dom::IDBTransaction> const&, RefPtr<mozilla::dom::Event> const&) [libxul.so]
mozilla::dom::EventTarget::DispatchEvent(mozilla::dom::Event&, mozilla::ErrorResult&) [libxul.so]
mozilla::DOMEventTargetHelper::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) [libxul.so]
mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) [libxul.so]
EventDispatcher::Dispatch []
EventDispatcher::Dispatch success []
mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) [libxul.so]
mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) [libxul.so]
mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) [libxul.so]
<name omitted> [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
AsyncFunctionNext [self-hosted:688:26]
0xff4eaa5ea9f []
js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
InterpretGeneratorResume [self-hosted:1146:33]
initializePublicDownloadList [resource://gre/modules/DownloadIntegration.jsm:231:36]
> loadPublicDownloadListFromStore [resource://gre/modules/DownloadIntegration.jsm:260:39]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]

Comment 1

[Emma Malysz]

Attachment: Bug 1649611: Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79484a596fa1
Remove OS.File usage from DownloadIntegration.jsm r=barret

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_DownloadCore.js

backout: https://hg.mozilla.org/integration/autoland/rev/29f93c17253e2fd3118ba85bfaf0427e4610c192

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=ObV0zR8YSY6QMSzz08ZX0g.0&revision=79484a596fa19aee7e02fb39a4616e45c547a5d0

failure log: https://treeherder.mozilla.org/logviewer?job_id=324784345&repo=autoland&lineNumber=4057

[task 2020-12-17T05:41:02.032Z] 05:41:02 INFO - TEST-START | toolkit/components/downloads/test/unit/test_DownloadCore.js
[task 2020-12-17T05:41:02.415Z] 05:41:02 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/downloads/test/unit/test_DownloadCore.js | xpcshell return code: 0
[task 2020-12-17T05:41:02.416Z] 05:41:02 INFO - TEST-INFO took 382ms
[task 2020-12-17T05:41:02.416Z] 05:41:02 INFO - >>>>>>>

Comment 4

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43f2f5614583
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on IOUtils.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/73234f99936238ab1afe3a19ef4c73ff8a75d79e
Log link: https://treeherder.mozilla.org/logviewer?job_id=326767380&repo=autoland&lineNumber=13221

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4934ec1fbb6f
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33f255475ce3
Backed out changeset 4934ec1fbb6f for causing xpcshell failures in test_DownloadCore.js

Comment 9

[Alexandru Michis [:malexandru]]

Backed out changeset 4934ec1fbb6f (Bug 1649611) for causing xpcshell failures in test_DownloadCore.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/33f255475ce3ca90d17d68f282d12b636bceab85

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=46713b21267a0769462b4a0cb6cbff4d3cbee901&searchStr=xpcshell&tochange=33f255475ce3ca90d17d68f282d12b636bceab85&selectedTaskRun=cm8QMzuKSE23OJgv7_-HFg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326892062&repo=autoland&lineNumber=7428

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c89276392499
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 11

[Atila Butkovits]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b9c2b81877d95f82c7da72b1b54df7f2f35da287

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Ya3MsPzeTLOSr8qiGyMP9g.0&revision=c89276392499944f2b5f78da08682a0df5ee9930&searchStr=linux%2Cx64%2Copt%2Cbuild-linux64%2Fopt%2Cb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=328022502&repo=autoland&lineNumber=14072

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7dd9e63300d
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 13

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/c7dd9e63300d

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out for causing bug 1689404: https://hg.mozilla.org/mozilla-central/rev/3bdf0c33844f1dc4198f0c44f1ff137b966cdc1d

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91181a01b68c
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 16

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_ioutils_mkdir.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/068f7227221736e268f9ca7c2560bd53d0e47cfc
Log link: https://treeherder.mozilla.org/logviewer?job_id=328265603&repo=autoland&lineNumber=2024

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aadba76932ea
Remove OS.File usage from DownloadIntegration.jsm and respect umask in IOUtils::SetPermissions r=barret

Comment 18

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/aadba76932ea