Closed Bug 1649631 Opened 3 years ago Closed 3 years ago

wasi issues in clang-11 builds

Categories

(Firefox Build System :: Toolchains, defect, P3)

defect

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: away, Assigned: shravanrn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm attempting to stand up some builds with clang trunk, currently version 11.

In version 11, the clang tree has a breaking change to wasm which requires that we pick up the corresponding change in wasi-libc which is available in wasi-sdk release 10.

However, when I update the rev for the wasi-sysroot task, the builds fail with:

 LucetcError { inner: ErrorMessage { msg: "Unknown module for symbol `wasi_snapshot_preview1::proc_exit`" }

From this point, I'm not super familiar, so this is just a guess, but: I notice that this symbol appeared in a recent change to the bytecodealliance/lucet repo. Does the PLSysSec fork need to pick it up?

Flags: needinfo?(nfroyd)
Severity: -- → S3
Priority: -- → P3

(In reply to :dmajor from comment #0)

From this point, I'm not super familiar, so this is just a guess, but: I notice that this symbol appeared in a recent change to the bytecodealliance/lucet repo. Does the PLSysSec fork need to pick it up?

My understanding is that yes, we would need to update to pick this symbol up. Shravan, is that correct?

Flags: needinfo?(nfroyd) → needinfo?(shravanrn)

Ping. LLVM 11 is now in release testing and I've had to disable wasm sandboxing in those builds. If there are any lurking compiler issues related to the wasi interaction, it would be much better if we could find and report them before the final release.

I apologize for the long overdue response. Have effectively been out of commission for a couple of weeks. I will investigate this weekend and will update the fork.

Flags: needinfo?(shravanrn)
Assignee: nobody → shravanrn

Just submitted the patch for this.
@dmajor, froydnj: if one of you could review and land this patch, that would be great.

Flags: needinfo?(nfroyd)
Flags: needinfo?(dmajor)
Flags: needinfo?(dmajor)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99b9eff39f1b
Fix wasi issues in clang-11 builds r=froydnj,dmajor
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Flags: needinfo?(froydnj+bz)
You need to log in before you can comment on or make changes to this bug.