1649636 - Allow `MediaControlKeySource` to know the browsing context ID of the tab that is being controlled

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

This is a request from GeckoView team, because they want to know which tab is being controlled and then they can call the corresponding callback to notify the embedded application.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1649636 - part1 : update controlled tab Id to the key source.

On GeckoView, when we update the property on the key source, such as the playback state, metadata. We want to know which tab that those properties change belong to.

Therefore, we create a method SetControlledTabBrowsingContextId() to tell the key source which tab is being controlled and all properties update should belong to that tab.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1649636 - part2 : implement `SetEnableFullScreen()` and `SetEnablePictureInPictureMode()` on `MediaControlKeyManager`.

We forgot to implement those two methods on MediaControlKeyManager, which would result in not able to propagate those update to the real key source that handle the platform level APIs, such as MPRIS, SMTC.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfaf4034a513
part1 : update controlled tab Id to the key source. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/85759048de42
part2 : implement `SetEnableFullScreen()` and `SetEnablePictureInPictureMode()` on `MediaControlKeyManager`. r=chunmin

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bfaf4034a513
https://hg.mozilla.org/mozilla-central/rev/85759048de42