Closed Bug 1649686 Opened 4 months ago Closed 3 months ago

Cross-origin isolated processes should be better identified in about:processes

Categories

(Core :: DOM: Content Processes, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: annevk, Assigned: brunobrt, Mentored)

References

(Blocks 2 open bugs)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(2 files)

As far as I can tell the name of a Fission process is registrable.domain (webIsolated) and a cross-origin isolated process is registrable.domain (web). (A non-Fission process is just web.)

Something like registrable.domain (COOP+COEP) for a cross-origin isolated process would be clearer. We could also use registrable.domain (crossOriginIsolated) though using origin might be confusing as we don't (yet) use that as our process boundary for these processes.

There seems to be a trivial bug in ChromeUtils::RequestProcInfo. We test whether web is a prefix before testing whether webCOOP+COEP is a prefix. We just need to change the order.

Assignee: nobody → dteller
Assignee: dteller → nobody
Mentor: dteller
Keywords: good-first-bug
Whiteboard: [lang=C++]

It's my first time here, could I work on this bug?

Yeah, https://searchfox.org/mozilla-central/source/dom/base/ChromeUtils.cpp#842 is the code you would have to change I think (by placing the COOP_COEP check before that check).

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is there it? am I missing a step somewhere?

(In reply to Bruno Bartolomasi from comment #4)

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is that it? am I missing a step somewhere?

(In reply to Bruno Bartolomasi from comment #4)

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is there it? am I missing a step somewhere?

Hi Bruno,

Thanks for contributing! I am not the purpose that you bookmarked bug1649689. Otherwise, they look good!
The steps I would suggest are:

  1. hg pull central
    Pull the latest code on the central
  2. hg update central
    Update to the top of it
  3. Fix the file
  4. hg commit -m "....."
  5. ./mach bootstrap
    Update tools for building the code
  6. ./mach build
    Build the code
  7. Push to try (But, I assume that you don't have permission to do that at the moment. So please skip this step if that's true. We can help you to do this step later)
  8. moz-phab submit . .
    Submit the patch to Phabricator and you can also use arc as an alternative tool if you prefer to. (Note that two arguments after submit represent from the source commit to the destination commit. And . represent the commit that you are on.)
  9. Send the review request to someone on Phabricator.

Hy, I'm newbie to open source contributions. Can anyone help me out to get started with it?

Assignee: nobody → brunobrt
Status: NEW → ASSIGNED
Fission Milestone: --- → M6b

(In reply to Soumya from comment #7)

Hy, I'm newbie to open source contributions. Can anyone help me out to get started with it?

Hi, and welcome to mozilla!
This specific bug is already handled by brunobrt, but I'm sure we can find something else for you to work on :)

Could you join us on #Introduction? That's the chat where we help new contributors!

Attachment #9163305 - Attachment description: Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix → Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix;r?yoric

Bruno, there was a conflict between your patch and another patch, so we couldn't land them at the same time.
I've resolved the conflict, let's see if we can land this now!

Pushed by dteller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1013eb60a84
Test whether webCOOP+COEP is a prefix before testing whether web is a prefix;r=Yoric
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.