1649686 - Cross-origin isolated processes should be better identified in about:processes

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Anne (:annevk)]

As far as I can tell the name of a Fission process is registrable.domain (webIsolated) and a cross-origin isolated process is registrable.domain (web). (A non-Fission process is just web.)

Something like registrable.domain (COOP+COEP) for a cross-origin isolated process would be clearer. We could also use registrable.domain (crossOriginIsolated) though using origin might be confusing as we don't (yet) use that as our process boundary for these processes.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

There seems to be a trivial bug in ChromeUtils::RequestProcInfo. We test whether web is a prefix before testing whether webCOOP+COEP is a prefix. We just need to change the order.

Comment 2

[Bruno Bartolomasi]

It's my first time here, could I work on this bug?

Comment 3

[Anne (:annevk)]

Yeah, https://searchfox.org/mozilla-central/source/dom/base/ChromeUtils.cpp#842 is the code you would have to change I think (by placing the COOP_COEP check before that check).

Comment 4

[Bruno Bartolomasi]

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is there it? am I missing a step somewhere?

Comment 5

[Bruno Bartolomasi]

(In reply to Bruno Bartolomasi from comment #4)

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is that it? am I missing a step somewhere?

Comment 6

[Tom Tung [:tt, :ttung]]

(In reply to Bruno Bartolomasi from comment #4)

Since this is my first time contributing, I'm still a little lost. I manage to download and build the source code, working with mozilla-unified. Here are the steps I made:
1- hg bookmark bug1649689
2- fix the file
3- hg commit -m "Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix"

Is there it? am I missing a step somewhere?

Hi Bruno,

Thanks for contributing! I am not the purpose that you bookmarked bug1649689. Otherwise, they look good!
The steps I would suggest are:

1. hg pull central
   Pull the latest code on the central
2. hg update central
   Update to the top of it
3. Fix the file
4. hg commit -m "....."
5. ./mach bootstrap
   Update tools for building the code
6. ./mach build
   Build the code
7. Push to try (But, I assume that you don't have permission to do that at the moment. So please skip this step if that's true. We can help you to do this step later)
8. moz-phab submit . .
   Submit the patch to Phabricator and you can also use arc as an alternative tool if you prefer to. (Note that two arguments after submit represent from the source commit to the destination commit. And . represent the commit that you are on.)
9. Send the review request to someone on Phabricator.

Comment 7

[Soumya]

Hy, I'm newbie to open source contributions. Can anyone help me out to get started with it?

Comment 8

[Bruno Bartolomasi]

Attachment: Bug 1649686 - Test whether webCOOP+COEP is a prefix before testing whether web is a prefix;r?yoric

Comment 9

[Bruno Bartolomasi]

Attachment: Bug 1649686 - Fix comment: 'DEFAULT_REMOTE_TYPE' is also a prefix of 'WITH_COOP_COEP_REMOTE_TYPE_PREFIX'

Depends on D83386

Comment 10

[David Teller [:Yoric] - still alive but not very active]

(In reply to Soumya from comment #7)

Hy, I'm newbie to open source contributions. Can anyone help me out to get started with it?

Hi, and welcome to mozilla!
This specific bug is already handled by brunobrt, but I'm sure we can find something else for you to work on :)

Could you join us on #Introduction? That's the chat where we help new contributors!

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Bruno, there was a conflict between your patch and another patch, so we couldn't land them at the same time.
I've resolved the conflict, let's see if we can land this now!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1013eb60a84
Test whether webCOOP+COEP is a prefix before testing whether web is a prefix;r=Yoric

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e1013eb60a84