Closed Bug 1649693 Opened 8 months ago Closed 6 months ago

Version check for binary doesn't recognize minor and esr releases

Categories

(Testing :: geckodriver, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1657876

People

(Reporter: whimboo, Unassigned)

References

(Regression)

Details

(Keywords: regression)

The current regular expression for the binary version detection doesn't recognize minor (eg. 77.0.1) and esr (eg. 68.0esr) releases:

https://searchfox.org/mozilla-central/rev/5a4aaccb28665807a6fd49cf48367d47fbb5a19a/testing/geckodriver/src/capabilities.rs#82

The version is always cut-off after the second number. For the above it means we get these versions: 77.0, and 68.0.

This case happens when there is no .ini file present. So probably on nix systems where a softlink is placed as /usr/bin/firefox.

As it looks like this is a problematic issue for all users of some Linux distributions where /usr/bin/firefox is a bash script linking to the real Firefox executable. None of them are able to launch Firefox. We should get this fixed asap and do a follow-up release.

James can you fix that regression? Thanks.

Blocks: 1649094
Flags: needinfo?(james)
Keywords: regression
Priority: P3 → P1
Regressed by: CVE-2020-15660

The appropriate geckodriver issue can be found at: https://github.com/mozilla/geckodriver/issues/1756

Depends on: 1657876
Priority: P1 → P2
Flags: needinfo?(james)

James, with bug 1657876 fixed what would be left-over to do here? Or is it just a dupe?

Flags: needinfo?(james)
Status: NEW → RESOLVED
Closed: 6 months ago
Flags: needinfo?(james)
Resolution: --- → DUPLICATE
Duplicate of bug: 1657876
No longer blocks: 1649094
You need to log in before you can comment on or make changes to this bug.