1657876 - ESR Firefox not supported in Rust mozversion

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, defect)

Description

[James Graham [:jgraham]]

This is because it has a version string ending "esr". This in turn seems to be the cause of https://github.com/mozilla/geckodriver/issues/1756

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1657876 - Improve parsing of the Firefox version string,

This doesn't add esr information to the version string, since that would be
a breaking change and require a major version bump

Comment 2

[James Graham [:jgraham]]

FWIW I tried a bigger/breaking change here: https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=EKDXaL0ZRDiaT5fdOhWR6A.0&tier=1%2C2%2C3&author=james%40hoppipolla.co.uk&fromchange=297265962160752fc9479c2adf30f9ffbb98836f Would be helpful for people to test that branch and verify that it works in more situations than just try

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1657876 - Add esr flag to mozversion rust,

Comment 4

[James Graham [:jgraham]]

Attachment: Bug 1657876 - Make mozversion::Error implement Clone,

Comment 5

[James Graham [:jgraham]]

Attachment: Bug 1657876 - Store the parsed version numbers for Firefox binaries,

Comment 6

[James Graham [:jgraham]]

Attachment: Bug 1657876 - Move firefox --version parsing into mozversion,

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49a8dfe53f37
Improve parsing of the Firefox version string, r=marionette-reviewers,webdriver-reviewers,whimboo

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/49a8dfe53f37