1649788 - Remove the unused "Show Header" checkbox found under IM prefs

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, task)

Description

[Richard Marti (:Paenglab)]

In the prefs under Chat there is a "Show Header" checkbox that, according to clokep, isn't used in TB.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1649788-remove-show-header.patch

Remove it.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 9160684 [details] [diff] [review]
1649788-remove-show-header.patch

Review of attachment 9160684 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with removing the checkbox, but I wonder if there's a way to test this patch before bug 1646611 is fixed (and it looks like that bug will need to touch imThemes.jsm at the same place as this patch).

(for some reason, splinter won't let me publish this comment without removing the '?' review flag; I'll add it back)

::: chat/modules/imThemes.jsm
@@ +725,4 @@
>    HTML += '<div id="Chat" aria-live="polite"></div>';
>    HTML += replaceKeywordsInHTML(
>      aTheme.html.footer,
>      headerFooterReplacements,

Should we rename `headerFooterReplacements` to `footerReplacements`?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1649788-remove-show-header.patch

Renamed headerFooterReplacements to footerReplacements.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 9160692 [details] [diff] [review]
1649788-remove-show-header.patch

Review of attachment 9160692 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay here. I think this change looks OK, although I'm unable to test it (as Florian alluded to).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e1a80855772
Remove the unused "Show Header" checkbox under IM prefs. r=clokep DONTBUILD

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/762c14692ab2
follow-up - Fix formatting error. rs=lint

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9160692 [details] [diff] [review]
1649788-remove-show-header.patch

[Triage Comment]
Taking this for Thunderbird 80b2 to avoid merging problems with bug 1646611.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8304abbd506b
https://hg.mozilla.org/releases/comm-beta/rev/cadd797484d7