1649806 - Allow optimizers to optimize tasks away, even when the "when" matches

Status: NEW

(Firefox Build System :: Task Configuration, enhancement)

Description

[Nathan Froyd [:froydnj]]

Maybe we already do this. If we don't, we should (the net has to be cast a little wider than changes that affect js/; whatever we package up for standalone spidermonkey would be a great starting point), and if we do, we should attempt to tighten the rules a little bit so that e.g. documentation changes don't trigger SM jobs, as https://hg.mozilla.org/integration/autoland/rev/cef2feefbf9a9417ed2858bda4b6d2283f72e481 did.

Comment 1

[Marco Castelluccio [:marco]]

We do, these are the current rules: https://searchfox.org/mozilla-central/rev/31d8600b73dc85b4cdbabf45ac3f1a9c11700d8e/taskcluster/ci/spidermonkey/kind.yml#29.

I've been thinking that maybe we should still allow optimizers to optimize these tasks away, even when the when matches.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Marco Castelluccio [:marco] from comment #1)

We do, these are the current rules: https://searchfox.org/mozilla-central/rev/31d8600b73dc85b4cdbabf45ac3f1a9c11700d8e/taskcluster/ci/spidermonkey/kind.yml#29.

I've been thinking that maybe we should still allow optimizers to optimize these tasks away, even when the when matches.

Ah, I didn't look far enough, thanks for the pointer. Those are some weird choices for when: web-platform tests? dom bindings? I don't think those files are touched during SM builds; maybe they're trying to say that certain javascript tests should be run? (I would assume that's what the reftest rule is trying to catch.)

Comment 3

[Marco Castelluccio [:marco]]

They were added in https://hg.mozilla.org/mozilla-central/rev/36a35446bb72 (bug 1365763) and in https://hg.mozilla.org/mozilla-central/rev/19e2b100fdb9 (bug 1481436).