1649899 - Pioneer study IDs collide with RemoteSettings record IDs

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Robert Helmer [:rhelmer]]

Bug 1646149 added support for pulling study metadata from RemoteSettings, but unfortunately uses an incompatible type for the ID (add-on IDs are freeform strings but RS requires UUIDs).

It'd make more sense to just let RS generate an ID for each record, and use a key that doesn't conflict like addon_id to store study add-on IDs.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: Bug 1649899 - do not use Pioneer study add-on IDs for RS records r?mythmon

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1646149

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9acd9e718df0
do not use Pioneer study add-on IDs for RS records r=mythmon

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_pioneer_ui.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4c65695984e371db6de906c56c5dc89284230f4e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308389782&repo=autoland&lineNumber=2879

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #4)

Backed out for bc failures on browser_pioneer_ui.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4c65695984e371db6de906c56c5dc89284230f4e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308389782&repo=autoland&lineNumber=2879

Thanks! This needed the ID names changed in the unit test too, sorry about that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0876ff41c1aa
do not use Pioneer study add-on IDs for RS records r=mythmon

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0876ff41c1aa

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rhelmer, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Robert Helmer [:rhelmer]]

Attachment: Uplift request for Beta

...

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 9160784 [details]
Bug 1649899 - do not use Pioneer study add-on IDs for RS records r?mythmon

Beta/Release Uplift Approval Request

• User impact if declined: about:pioneer will not show available studies
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1649899
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only applies to about:pioneer
• String changes made/needed: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160784 [details]
Bug 1649899 - do not use Pioneer study add-on IDs for RS records r?mythmon

Approved for 79.0b5.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cdbc2452bb6d