1649970 - [MediaControl-Windows] Correct the index for fetching next available image

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[C.M.Chang[:chunmin] | PTO]

Suppose the current artwork is <img A, img B, img C> and Firefox is currently fetching img B, whose index is 1 in the artwork. If the artwork is updated to <img D, img B> before img B is fetched, then Firefox will skip fetching a new image since img B is also an acceptable choice in the new artwork. However, if Firefox fails to fetch img B, in the current implementation, a new image at (previous index + 1) would be fetched, as a fallback plan. In the above case, the index is 2, which is out of the bound of the new artwork.

Instead of caching the previous index of an image in the artwork and using the previous index plus 1 as the index of the next available image, the index of the next available image should be reset every the artwork is updated.

Comment 1

[C.M.Chang[:chunmin] | PTO]

Attachment: Bug 1649970 - Correct the index for fetching next available image

Suppose the current artwork is <img A, img B, img C> and Firefox is
currently fetching img B, whose index is 1 in the artwork. If the
artwork is updated to <img D, img B> before img B is fetched, then
Firefox will skip fetching a new image since img B is also an acceptable
choice in the new artwork. However, if Firefox fails to fetch img B, in
the current implementation, a new image at (previous index + 1) would be
fetched, as a fallback plan. In the above case, the index is 2, which is
out of the bound of the new artwork.

Instead of caching the previous index of an image in the artwork and
using the the previous index plus 1 as the index of the next available
image, the index of the next available image should be reset every time
when artwork is updated

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647434

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1934bb1c06d
Correct the index for fetching next available image r=alwu

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d1934bb1c06d