Closed Bug 1647434 Opened 5 years ago Closed 5 years ago

[MediaControl-Windows] Rework image cache mechanism for SMTC

Categories

(Core :: Audio/Video: Playback, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(3 files)

There are two problem in the current cache mechanism:

  1. The image url would be cached if it's valid. If the image fails to be set a the thumbnail and the next song uses the same image, the thumbnail would not be updated.
  2. If the Artwork for track 1, 2 are <image A, image B> and <image B, image C> respectively, when the track of the media session is switched from 2 to 1, the track image (Thumbnail on SMTC) would be updated from image B to image A. However, we could skip the update since image B is acceptable for track 1.
Attachment #9158316 - Attachment description: Bug 1647434 - Simplify image cache mechanism for SMTC → Bug 1647434 - Rework image cache mechanism for SMTC
Summary: [MediaControl-Windows] Simplify image cache mechanism for SMTC → [MediaControl-Windows] Rework image cache mechanism for SMTC
Attachment #9158316 - Attachment description: Bug 1647434 - Rework image cache mechanism for SMTC → Bug 1647434 - P1: Rework image cache mechanism for SMTC

Depends on D80524

Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f224e05e4ec3 P1: Rework image cache mechanism for SMTC r=alwu https://hg.mozilla.org/integration/autoland/rev/c7728ae84546 P2: Remove RefreshDisplay() r=alwu https://hg.mozilla.org/integration/autoland/rev/15ade6b9452b P3: Set mThumbnailUrl in {Clear, Set}Thumbnail r=alwu
Regressions: 1649970
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: