1650041 - Multiple address book papercuts

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

I have a number of minor address book problems that need fixing, so I'm going to fix them all in one bug.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - Always use second argument when calling nsIAbCard.getProperty. r?pmorris

The second argument is not optional, but we've been getting away with it in most cases because they
don't pass through XPCOM. It is however a bug that would cause problems in some edge cases.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - In ABView, call QueryInterface on objects passed through the observer service. r?pmorris

Objects that we get from the observer service are nsISupports. We can't guarantee the properties
we want to use on them are there without QueryInterface. In most cases they are because we're just
passing JS objects around, but that isn't always the case.

Plus I found a bug where the code expects an nsIAbCard but actually gets an nsIAbDirectory.

Depends on D81982

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - Fix two nits that occur when editing mailing lists. r?pmorris

If the list has zero members, the dialog's <richlistbox> has no item to duplicate when making a
new row. In this case do the same thing as if a new mailing list is being created.

If the list is not the current directory when editing is complete, don't refresh the view.

Depends on D81983

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - Retain selection when sorting the address book contacts list. r?pmorris

Depends on D81984

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - Add newly created mailing lists to the view

This didn't get done when the view was rewritten because the UI always switches to a new list, but
that's about to change. Also, the contacts sidebar doesn't switch to a new list on creation, so
that showed bad information.

This patch comments outs a few lines that are about to change anyway, so that the changed test
works.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - When adding a new address book or list, only change the UI if the change was made with the UI

Previously, the UI would detect something was new and change to it immediately. With this patch,
that will not happen. Instead, the dialogs for creating new books and lists return the URI of the
new object, and the change happens when the dialog closes.

This patch finally removes the comments "we can optimize this later" added 9 years ago. I guess
now is later.

Depends on D82313

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1650041 - Refactor tests in mail/components/addrbook

Depends on D82314

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e06df46ec03
Always use second argument when calling nsIAbCard.getProperty. r=pmorris
https://hg.mozilla.org/comm-central/rev/6aa2a15cefb7
In ABView, call QueryInterface on objects passed through the observer service. r=pmorris
https://hg.mozilla.org/comm-central/rev/6ddc057f6870
Fix two nits that occur when editing mailing lists. r=pmorris
https://hg.mozilla.org/comm-central/rev/e4f6df2deede
Retain selection when sorting the address book contacts list. r=pmorris

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/77ae3e1ace65
Add newly created mailing lists to the view r=pmorris
https://hg.mozilla.org/comm-central/rev/6d2f5bb09a29
When adding a new address book or list, only change the UI if the change was made with the UI r=pmorris
https://hg.mozilla.org/comm-central/rev/1dc8a1aba93b
Refactor tests in mail/components/addrbook r=pmorris

Comment 10

[Geoff Lankow (:darktrojan)]

I think I'll call this one fixed. There's bound to be more but all the changes I've been working on here have now landed.

Comment 11

[Takanori MATSUURA]

Removing the "leave-open" keyword before the last push will make this bug automatically closed.

Comment 12

[Geoff Lankow (:darktrojan)]

Comment on attachment 9160876 [details]
Bug 1650041 - Always use second argument when calling nsIAbCard.getProperty. r?pmorris

Approval request for all the patches on this bug. Most of it is covered by new tests, but it should spend a good while on beta to see if anything comes out of the woodwork.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to Geoff Lankow (:darktrojan) from comment #12)

Approval request for all the patches on this bug. Most of it is covered by new tests, but it should spend a good while on beta to see if anything comes out of the woodwork.

per above, 80 beta just shipped, so not taking on 78.1.1.
Are you thinking these should be on beta for 3 weeks - thus we'd uplift to 78.2.0?

Comment 14

[Geoff Lankow (:darktrojan)]

That's what I had in mind, yes.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9161517 [details]
Bug 1650041 - Refactor tests in mail/components/addrbook

[Triage Comment]
Approved for esr78

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9161516 [details]
Bug 1650041 - When adding a new address book or list, only change the UI if the change was made with the UI

[Triage Comment]
Approved for esr78

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9161515 [details]
Bug 1650041 - Add newly created mailing lists to the view

[Triage Comment]
Approved for esr78

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9160878 [details]
Bug 1650041 - Fix two nits that occur when editing mailing lists. r?pmorris

[Triage Comment]
Approved for esr78

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9160877 [details]
Bug 1650041 - In ABView, call QueryInterface on objects passed through the observer service. r?pmorris

[Triage Comment]
Approved for esr78

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9160876 [details]
Bug 1650041 - Always use second argument when calling nsIAbCard.getProperty. r?pmorris

[Triage Comment]
Approved for esr78

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9160879 [details]
Bug 1650041 - Retain selection when sorting the address book contacts list. r?pmorris

[Triage Comment]
Approved for esr78

Comment 22

[Geoff Lankow (:darktrojan)]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/f5cb8ee13f75
https://hg.mozilla.org/releases/comm-esr78/rev/c779449beb98
https://hg.mozilla.org/releases/comm-esr78/rev/8c9e359ab819
https://hg.mozilla.org/releases/comm-esr78/rev/aed3689970ee
https://hg.mozilla.org/releases/comm-esr78/rev/3315046778c4
https://hg.mozilla.org/releases/comm-esr78/rev/e075d99bb8a7
https://hg.mozilla.org/releases/comm-esr78/rev/510eefa7bed0