1650240 - Superfluous text field border when editing recipient pills

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Double borders when editing recipient pill

Seen on trunk (80.0a1 (2020-07-02) (64-bit)) and 78.0b4 (32-bit), Win10

When tabbing around and then editing a pill, a visual glitch of double border occurs.

STR

1.) compose, add 1 recipient, press Enter
2.) press tab (sic!) twice (sic!) into body, then edit pill (in any way)
Weird, any two tab key presses in that area will reliably trigger this.
Without using tab, bug not seen.

actual result

• see screenshot, visual glitch of double border

expected

• pill border only

Comment 1

[Alessandro Castellani [:aleca]]

Definitely a regression

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=01b3a50f3311f7b1d4fdfea8581532c31ab3e67a&tochange=10edd0b971021b4d16a78e4fdbb299357e2a36b4
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=385f49adaf00d02fc8e04da1e0031e3477182d67&tochange=590613078c743f089f01b3f43118524e9553dd0b

Suspect:
0010e22f0dafa5d3f8b7fe095dd0ca51b745d38b Emilio Cobos Álvarez — Bug 1311444 - Disable outline-style: auto rendering on themed widgets, and use it for elements for which we otherwise disable outlines by default. r=Jamie,jfkthame
40e959f28932b1a89bd19c89600bca555ff2ae68 Emilio Cobos Álvarez — Bug 1311444 - Disable some undesired outlines in the front-end. r=dao

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1650240-address-pill-no-outline.patch

Thanks Alice. One more of this outline removal bugs.

[Approval Request Comment]
Regression caused by (bug #): 1311444
User impact if declined: unneded border when editing the address
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9161172 [details] [diff] [review]
1650240-address-pill-no-outline.patch

Review of attachment 9161172 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f9629f7a292
Disable undesired outline in address pill when editing. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9161172 [details] [diff] [review]
1650240-address-pill-no-outline.patch

Approved for beta, when we build 79

Comment 7

[Geoff Lankow (:darktrojan)]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/b2ad6c163f96

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9161172 [details] [diff] [review]
1650240-address-pill-no-outline.patch

Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/ce4f5c65346c